Drop chown of tpls folder to allow config maps mounted over it #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's fine as we are just reading from this path. Can you update PIDs in docker-rtorrent-rutorrent/test/rtorrent-rutorrent.env Lines 2 to 3 in 1398e24 1010 to make sure we can still read files?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run the image inside k8s and use a configmap to use an extended .rtorrent.rc template. As a config map is always read only this chown fails the container startup.
As the templates can be read by the init script anyway I think it's safe to remove the chown and by that allow the use of configmaps in k8s. I hope i do not miss an obvious case where this is needed.