Move download directory configuration to .rtorrent.rc

[joe-p]

This addresses the issue of download paths not being easily configurable (#105, #7, #44, #57).

As @crazy-max said in his comment on #105 the conventional solution here is to use bind-mounts rather than changing directories in-solution.

@hollanbm, however, raised an important scenario in which that is not applicable. If this container needs to communicate paths to external services, simply using a bind mount is not a viable solution. One might think it's just easy enough to add the /downloads mount on any other container that needs access to the path, but this breaks hardlinking. A file can't be hardlinked across bind mounts. As such, the only solution is to change the paths in the configuration file.

This PR simply moves the configuration of download paths from .rtlocal.rc, which is effectively read-only, to .rtorrent.rc, which can modified by the user without having to rebuild the container.

[katbyte]

👍 this would have come in very handy for me today, and you can't just copy it in so i had to just hide the real paths from the container in the end

[crazy-max]

It will break init scripts and configuration if changed to smth else:

docker-rtorrent-rutorrent/rootfs/etc/cont-init.d/02-fix-perms.sh

Line 7 in c99391c

/downloads \

docker-rtorrent-rutorrent/rootfs/etc/cont-init.d/02-fix-perms.sh

Line 20 in c99391c

/downloads

docker-rtorrent-rutorrent/rootfs/etc/cont-init.d/03-config.sh

Lines 147 to 148 in c99391c

	/downloads/complete \
	/downloads/temp

docker-rtorrent-rutorrent/rootfs/tpls/etc/nginx/conf.d/webdav.conf

Line 5 in c99391c

root /downloads/complete;

docker-rtorrent-rutorrent/rootfs/tpls/etc/nginx/conf.d/webdav.conf

Line 23 in c99391c

root /downloads/complete;

[k44sh]

I forked this repository, and made changes for essentially the same reason.
I wanted to have more flexibility with hard links for Sonarr and Radarr.
It is also necessary to modify the bootstrap config .rtlocal.rc and requires quite a few changes in most scripts.

[NepBlanc]

https://trash-guides.info/Hardlinks/How-to-setup-for/Docker/#:~:text=The%20default%20path,delete%20is%20used.

Why is it set up like this? And not the same as well described in the link above.
it is alright but for a more unified way of doing it, I think you need to explain to your users more and have a more flexible setup than the confines we have here.

Many of your potential user bases are using Sonarr, Radarr, (etc)rr.
I do not think the way this is set up would be helpful to anybody, what you are doing is not really helping your user base but more just hindering it.
as I see it you need to set a more robust way of setting those folders manually and set some environment variables so that there is a better way to do this.
I think you need to take into account that it has been repeated before how backward it is.

I agree with K44sh which has forked this repo and made the necessary edits.

[XxAcielxX]

I have made my own custom version of the image where the downloads are saved to location /downloads by default and few other changes as well. Try it out.
https://github.com/XxAcielxX/docker-rutorrent

[jmatraszek]

Thanks @XxAcielxX, I was getting mad trying to configure rtorrent for the simplest use case possible (manually pick a download folder and download the files exactly there), but failed to do so. Switched to your image and it worked like a charm!