Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ROLE keyword for autocomplete & autocapitalize #414

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Added ROLE keyword for autocomplete & autocapitalize #414

merged 1 commit into from
Dec 8, 2023

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Dec 8, 2023

Relates to: crate/crate#12109

@matriv matriv requested a review from amotl December 8, 2023 10:22
@matriv matriv force-pushed the mt/add-role-keyword branch from cd8b8f0 to dd1da29 Compare December 8, 2023 10:24
amotl
amotl approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@matriv matriv merged commit 875c4ac into master Dec 8, 2023
21 checks passed
@matriv matriv deleted the mt/add-role-keyword branch December 8, 2023 10:35
@amotl
Copy link
Member

amotl commented Jan 12, 2024

Hi. I've just verified that the role keyword is already part of Admin UI.

-- https://github.com/crate/crate-admin/blob/1.24.6/app/scripts/controllers/console.js#L476

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amotl amotl amotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matriv @amotl