Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giskard fallschool changes #226

Merged
merged 14 commits into from
Dec 4, 2024

Conversation

AbdelrhmanBassiouny
Copy link
Collaborator

Updates to Giskard interface like:

Allow / Disable gripper collision fix where incorrect links were used + added a configuration parameter and a passable argument to achieve_cartesian_goal.

Use of seed configuration only in projection mode.

Added MovementType Enum to use the correct motion in Giskard.

Added a world configuration parameter that controls the use of Giskard monitors.

Added a parameter that controls the pickup prepose distance (I think the best solution is to use the knowledge here).

config/multiverse_conf.py Show resolved Hide resolved
config/world_conf.py Show resolved Hide resolved
demos/pycram_multiverse_demo/fallschool_demo.py Outdated Show resolved Hide resolved
src/pycram/designators/action_designator.py Outdated Show resolved Hide resolved
src/pycram/designators/action_designator.py Outdated Show resolved Hide resolved
src/pycram/designators/action_designator.py Outdated Show resolved Hide resolved
src/pycram/designators/action_designator.py Outdated Show resolved Hide resolved
src/pycram/external_interfaces/giskard.py Outdated Show resolved Hide resolved
src/pycram/external_interfaces/giskard.py Show resolved Hide resolved
src/pycram/external_interfaces/giskard.py Outdated Show resolved Hide resolved
AbdelrhmanBassiouny and others added 14 commits December 3, 2024 10:39
… giskard.

Updated robot_description usage from old version to new version in Giskard.

Added options for disabling monitors and allowing gripper collision in achieve_cartesian_goal in Giskard and added these options to the configurations of the world.

Added a globale variable that indicates if robokudo was found or not to avoid using real detection processs module if Robokudo was not found.
…veTCP.

Navigate rotation then translation when transporting to avoid wierd arm pose.
@AbdelrhmanBassiouny AbdelrhmanBassiouny force-pushed the giskard_fallschool_changes branch from 0e69734 to be45a41 Compare December 3, 2024 10:09
@@ -1,6 +1,6 @@
#!/bin/bash
source /opt/ros/noetic/setup.bash
source ~/catkin_ws/devel/setup.bash
source ~/cram_ws/devel/setup.bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will not work in most cases since a lot of people name this differently

@Tigul Tigul merged commit 3f17584 into cram2:dev Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants