-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Giskard fallschool changes #226
Merged
Tigul
merged 14 commits into
cram2:dev
from
AbdelrhmanBassiouny:giskard_fallschool_changes
Dec 4, 2024
Merged
Giskard fallschool changes #226
Tigul
merged 14 commits into
cram2:dev
from
AbdelrhmanBassiouny:giskard_fallschool_changes
Dec 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsch420
requested changes
Nov 26, 2024
Tigul
requested changes
Nov 28, 2024
Tigul
requested changes
Dec 2, 2024
… giskard. Updated robot_description usage from old version to new version in Giskard. Added options for disabling monitors and allowing gripper collision in achieve_cartesian_goal in Giskard and added these options to the configurations of the world. Added a globale variable that indicates if robokudo was found or not to avoid using real detection processs module if Robokudo was not found.
…e kept while navigating.
corrected adding of gripper groups
corrected adding of gripper groups
…veTCP. Navigate rotation then translation when transporting to avoid wierd arm pose.
AbdelrhmanBassiouny
force-pushed
the
giskard_fallschool_changes
branch
from
December 3, 2024 10:09
0e69734
to
be45a41
Compare
Tigul
reviewed
Dec 4, 2024
@@ -1,6 +1,6 @@ | |||
#!/bin/bash | |||
source /opt/ros/noetic/setup.bash | |||
source ~/catkin_ws/devel/setup.bash | |||
source ~/cram_ws/devel/setup.bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work in most cases since a lot of people name this differently
Tigul
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Giskard interface like:
Allow / Disable gripper collision fix where incorrect links were used + added a configuration parameter and a passable argument to achieve_cartesian_goal.
Use of seed configuration only in projection mode.
Added MovementType Enum to use the correct motion in Giskard.
Added a world configuration parameter that controls the use of Giskard monitors.
Added a parameter that controls the pickup prepose distance (I think the best solution is to use the knowledge here).