Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resources]: Added additional resources #148

Closed
wants to merge 9 commits into from

Conversation

pkehr
Copy link
Contributor

@pkehr pkehr commented Apr 22, 2024

Added additional models for objects, robots and worlds. The objects are a smaller stl version of their 3d models from https://github.com/Multiverse-Framework/Multiverse-Assets/tree/main/unchecked/objects .
Restructured objects, robots and worlds into seperate directories.
Adjusted default paths for robots and search for resources in all subdirectories.

…anager searches in all subdirectories of resources
@sunava sunava self-requested a review April 22, 2024 12:44
@sunava
Copy link
Collaborator

sunava commented Apr 22, 2024

Please fix tests aswell.

Copy link
Collaborator

@tomsch420 tomsch420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very sure that all resource files should not be tracked in git. Talk to @Tigul about his vision for that.

@sunava
Copy link
Collaborator

sunava commented Apr 22, 2024

waiting for the meeting tmr to approve this. but looks good

@Tigul
Copy link
Collaborator

Tigul commented Apr 23, 2024

Maybe we could make a seperate Repo and use it as a submodule for the meshes.

@sunava
Copy link
Collaborator

sunava commented Apr 23, 2024

will rework this based on the discussion today

@sunava sunava closed this Apr 23, 2024
hawkina pushed a commit to hawkina/pycram that referenced this pull request Oct 31, 2024
[binder] Reduced webapps.json to reduce memory usage
hawkina pushed a commit to hawkina/pycram that referenced this pull request Mar 9, 2025
[MS2-restaurant] Changed some stuff in NLP to make it more smother
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants