Updated the CI pipeline #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tigul
requested changes
Mar 15, 2024
.github/workflows/new-pycram-ci.yml
Outdated
| run: | | ||
| sudo -s | ||
| source /opt/ros/noetic/setup.bash | ||
| cd /opt/ros/overlay_ws |
There was a problem hiding this comment.
What do the first three statements, wouldn't the source, roscd and pytest be enough?
| types: | ||
| - completed | ||
| workflow_dispatch: # manual run | ||
| inputs: |
There was a problem hiding this comment.
The Dockerfile only needs to be updated if the requirements change. We could also automate this: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-your-workflow-only-when-a-push-affects-specific-files
hardcode docker image into workflow
hawkina
pushed a commit
to hawkina/pycram
that referenced
this pull request
Oct 23, 2024
Added demos as packages and adjusted vib-imports
mkhoshnam
pushed a commit
to mkhoshnam/pycram
that referenced
this pull request
Nov 26, 2024
Updated the CI pipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make a new docker repository and add the docker image tag as DOCKER_IMAGE under GitHub variables.