operator() of `CoeffUnaryOp needs to return by value.

Otherwise there is a dangling reference.
cpp977 · Feb 24, 2024 · 6aa5378 · 6aa5378
1 parent 9d614ea
commit 6aa5378
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -48,7 +48,6 @@ add_executable(Instantiator Instantiator.cpp
   src/Template.cpp)
 
 # set_target_properties(Instantiator PROPERTIES SUFFIX ${LLVM_VERSION_MAJOR})
-target_compile_options(Instantiator -Wno-return-stack-address)
 
 message(STATUS ${CMAKE_SOURCE_DIR})
 target_include_directories(Instantiator PRIVATE ${LLVM_INCLUDE_DIRS} ${CLANG_INCLUDE_DIRS} ${CMAKE_SOURCE_DIR}/include)

diff --git a/tests/Math/include/Math/CoeffUnaryOp.hpp b/tests/Math/include/Math/CoeffUnaryOp.hpp
@@ -34,7 +34,7 @@ class CoeffUnaryOp : public MatrixBase<CoeffUnaryOp<XprType_, ReturnScalar>>
     constexpr auto rows() const { return Rows; }
     constexpr auto cols() const { return Cols; }
 
-    const Scalar& operator()(std::size_t row, std::size_t col) const;
+    Scalar operator()(std::size_t row, std::size_t col) const;
 
 protected:
     const XprType& m_refexpr;

diff --git a/tests/Math/src/CoeffUnaryOp.cpp b/tests/Math/src/CoeffUnaryOp.cpp
@@ -7,7 +7,7 @@
 namespace Math {
 
 template <typename XprType, typename ReturnScalar>
-const ReturnScalar& CoeffUnaryOp<XprType, ReturnScalar>::operator()(std::size_t row, std::size_t col) const
+ReturnScalar CoeffUnaryOp<XprType, ReturnScalar>::operator()(std::size_t row, std::size_t col) const
 {
     return m_func(m_refexpr(row, col));
 }