Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt code to run more easily on other chains #125

Merged
merged 8 commits into from
Feb 17, 2025
Merged

Conversation

harisang
Copy link
Contributor

This PR proposes some minimal changes so that the daemon can be deployed on all chains. Note that constants/thresholds have not been edited, so the current values only make sense for chains where the native token is ETH.

@harisang harisang requested a review from fhenneke February 13, 2025 02:01
src/apis/orderbookapi.py Outdated Show resolved Hide resolved
src/daemon.py Outdated Show resolved Hide resolved
Copy link
Contributor

@fhenneke fhenneke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look correct.

I am assuming that some of the other tests will fail with these changes applied. Either they should be adapted as well (this PR) or they should be deleted (some other PR).

@harisang harisang merged commit 3730aa9 into main Feb 17, 2025
4 checks passed
@harisang harisang deleted the extend_to_all_chains branch February 17, 2025 13:06
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants