From 289eb906b055f32169ceba4139fb1e44a8f60921 Mon Sep 17 00:00:00 2001 From: Felix Henneke Date: Tue, 19 Dec 2023 15:28:37 +0100 Subject: [PATCH] remove two variables which were not really used and resulted in linter error --- .../combinatorial_auction_surplus_test.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/monitoring_tests/combinatorial_auction_surplus_test.py b/src/monitoring_tests/combinatorial_auction_surplus_test.py index f95773f..83c59be 100644 --- a/src/monitoring_tests/combinatorial_auction_surplus_test.py +++ b/src/monitoring_tests/combinatorial_auction_surplus_test.py @@ -48,7 +48,6 @@ def run_combinatorial_auction(self, competition_data: dict[str, Any]) -> bool: """ solutions = competition_data["solutions"] - winning_solution = competition_data["solutions"][-1] aggregate_solutions: list[dict[tuple[str, str], Fraction]] = [] for solution in solutions: @@ -59,8 +58,6 @@ def run_combinatorial_auction(self, competition_data: dict[str, Any]) -> bool: return False aggregate_solutions.append(aggregate_solution) - winning_aggregate_solution = aggregate_solutions[-1] - baseline_surplus = self.compute_baseline_surplus(aggregate_solutions) filter_mask = self.filter_solutions(aggregate_solutions, baseline_surplus) winning_solutions = self.determine_winning_solutions( @@ -80,9 +77,7 @@ def run_combinatorial_auction(self, competition_data: dict[str, Any]) -> bool: sum(surplus for _, surplus in token_pair_surplus.items()) for _, token_pair_surplus in winning_solvers.items() ) - total_surplus = sum( - surplus for _, surplus in winning_aggregate_solution.items() - ) + total_surplus = sum(surplus for _, surplus in aggregate_solutions[-1].items()) a_abs_eth = total_combinatorial_surplus - total_surplus @@ -90,8 +85,8 @@ def run_combinatorial_auction(self, competition_data: dict[str, Any]) -> bool: [ "Combinatorial auction surplus test:", f"Tx Hash: {competition_data['transactionHash']}", - f"Winning Solver: {winning_solution['solver']}", - f"Winning surplus: {self.convert_fractions_to_floats(winning_aggregate_solution)}", + f"Winning Solver: {competition_data['solutions'][-1]['solver']}", + f"Winning surplus: {self.convert_fractions_to_floats(aggregate_solutions[-1])}", f"Baseline surplus: {self.convert_fractions_to_floats(baseline_surplus)}", f"Solutions filtering winner: {filter_mask[-1]}", f"Solvers filtering winner: {solutions_filtering_winner}",