Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text clickable for radio buttons in diagnosis code page #470

Merged
merged 3 commits into from
Aug 11, 2020
Merged

Make text clickable for radio buttons in diagnosis code page #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d91617c
Gives each radio button an id and makes use of the <label> tag's for …
ibeckermayer Aug 10, 2020
e3483ad
Merge branch 'dev' into select-radio-button-on-label-click
ibeckermayer Aug 11, 2020
25198ef
removing superfluous defaults from col-2-sub-header styling
ibeckermayer Aug 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 30 additions & 9 deletions frontend/client/src/screens/CodeValidations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,27 +130,48 @@ const CodeValidationsBase = observer((props) => {
</div>
<form id="radio-form" className="col-2">
<div className="radio">
<input className="radio-input" name="testType" type="radio" onClick={handleRadio} value="confirmed"></input>
<div className="col-2-header-container">
<input
className="radio-input"
name="testType"
type="radio"
onClick={handleRadio}
id="confirmed"
value="confirmed"
></input>
<label htmlFor="confirmed" className="col-2-header-container">
<div className="col-2-header">Confirmed Positive Test</div>
<div className="col-2-sub-header">Confirmed positive result from an official testing source.</div>
</div>
</label>
</div>

<div className="radio">
<input className="radio-input" name="testType" type="radio" onClick={handleRadio} value="likely"></input>
<div className="col-2-header-container">
<input
className="radio-input"
name="testType"
type="radio"
onClick={handleRadio}
id="likely"
value="likely"
></input>
<label htmlFor="likely" className="col-2-header-container">
<div className="col-2-header">Likely Positive Diagnosis</div>
<div className="col-2-sub-header">Clincial diagnosis without a test.</div>
</div>
</label>
</div>

<div className="radio">
<input className="radio-input" name="testType" type="radio" onClick={handleRadio} value="negative"></input>
<div className="col-2-header-container">
<input
className="radio-input"
name="testType"
type="radio"
onClick={handleRadio}
id="negative"
value="negative"
></input>
<label htmlFor="negative" className="col-2-header-container">
<div className="col-2-header">Confirmed Negative Test</div>
<div className="col-2-sub-header">Confirmed negative result from an official testing source.</div>
</div>
</label>
</div>
</form>
</div>
Expand Down
8 changes: 6 additions & 2 deletions frontend/client/styles/screens/code_validations.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,12 @@
}

.radio {
:hover {
cursor: pointer;
}
display: flex;
margin-bottom: 20px;

.col-2-header {
font-weight: 600;
font-size: 16px;
Expand All @@ -92,6 +95,7 @@

.col-2-sub-header {
color: $darkMediumGray;
font-size: 14px;
}
}

Expand Down Expand Up @@ -164,7 +168,7 @@
margin-bottom: 40px;

@include media('>phone') {
// ensures all the text fits in one line
// ensures all the text fits in one line
width: 620px;
flex-direction: row;
}
Expand Down