Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make text clickable for radio buttons in diagnosis code page #470

Merged
merged 3 commits into from
Aug 11, 2020

Conversation

ibeckermayer
Copy link
Contributor

Gives each radio button an id and makes use of the <label> tag's for attribute to cause clicking on the label to select the radio button (https://stackoverflow.com/a/1146936)

closes #464

…attribute to cause clicking on the label to select the radio button (https://stackoverflow.com/a/1146936)
Copy link
Contributor

@colbymorrison colbymorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. Also, it is not due to this PR but the white circle in the radio button looks off-centered in a way it didn't before. Did this get changed in another PR?

radio

@@ -91,6 +94,10 @@

.col-2-sub-header {
color: $darkMediumGray;
font-family: Montserrat;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove this line. Montserrat is set by default in application.scss

@@ -91,6 +94,10 @@

.col-2-sub-header {
color: $darkMediumGray;
font-family: Montserrat;
font-size: 14px;
font-weight: normal;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line and line below (99-100), these are the defaults

@ibeckermayer
Copy link
Contributor Author

See comments. Also, it is not due to this PR but the white circle in the radio button looks off-centered in a way it didn't before. Did this get changed in another PR?

radio

Browser/OS?

@ibeckermayer
Copy link
Contributor Author

See comments. Also, it is not due to this PR but the white circle in the radio button looks off-centered in a way it didn't before. Did this get changed in another PR?
radio

Browser/OS?

#477

@ibeckermayer ibeckermayer merged commit e9b5b45 into dev Aug 11, 2020
@ibeckermayer ibeckermayer deleted the select-radio-button-on-label-click branch August 11, 2020 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make text clickable for radio buttons in diagnosis code page
2 participants