Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test ResetPasswordModal and ChangePasswordModal #457

Merged
merged 19 commits into from
Aug 11, 2020
Merged

Test ResetPasswordModal and ChangePasswordModal #457

merged 19 commits into from
Aug 11, 2020

Conversation

colbymorrison
Copy link
Contributor

@colbymorrison colbymorrison commented Aug 6, 2020 •
edited
Loading

Depends on #446. New file in this PR is __tests__/reset_password.test.js

Tests

Updates

  • Use global waitForComponentToPaint
  • More consistent test naming
  • Fix new password == current password test

@ibeckermayer
Manually resolving conflicts. Retrofitted auth.setPersistence to be N…
2906e69 
…ONE vs SESSION depending on the context. (I expect this to be simplified in an upcoming PR where we transition to NONE exclusively).
ibeckermayer
ibeckermayer suggested changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@ibeckermayer ibeckermayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

frontend/client/__tests__/reset-password.test.js Outdated Show resolved Hide resolved
frontend/client/__tests__/reset-password.test.js Outdated Show resolved Hide resolved
@ibeckermayer ibeckermayer merged commit 9fa777b into dev Aug 11, 2020
@ibeckermayer ibeckermayer deleted the test-password-reset branch August 11, 2020 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibeckermayer ibeckermayer ibeckermayer approved these changes

@jcolla-holla jcolla-holla Awaiting requested review from jcolla-holla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colbymorrison @ibeckermayer @serenac26 @jcolla-holla