Reset Password Fix #419
Merged
Reset Password Fix #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colbymorrison
approved these changes
Jul 28, 2020
|
Looking back at Slack, this issue was in regard to the new user case, when we ask new users to change their password on their first login. This uses the same code as the Forgot Password case, both use |
See: #416 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #416
Reset password modal now rejects your new password if it is the same as the inputted current password. Updated
onChangefunction ofResetPasswordModalBaseto use a switch statement for better readability/efficiency.Note: this does not fix issues associated with the "forgot your password" reset via the login page (you are able to use the same password as the previous).