Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make form checking design consistent #299

Open
ibeckermayer opened this issue Jun 25, 2020 · 0 comments
Open

Make form checking design consistent #299

ibeckermayer opened this issue Jun 25, 2020 · 0 comments
Assignees
Labels
design design / style issue
Milestone

Comments

@ibeckermayer
Copy link
Contributor

Currently, for the Change Password Modal (the one that pops up when you click "Change Password" on the Settings page) has a grayed out, disabled button when the form is invalid. On the other hand, the other modals don't have the grayed out buttons. Let's make this consistent.

I think we should always allow the user to press the button, and then pop up the error messages on form submit, if they failed to fill out the form correctly. With the grayed out option, we always need to show the user the error message while they're typing (so that they understand why the button is grayed out), which is semantically false (there's not actually an error yet, they're just in the process of typing).

@ibeckermayer ibeckermayer added this to the Post V3 milestone Jun 25, 2020
@ibeckermayer ibeckermayer added the design design / style issue label Jun 25, 2020
@colbymorrison colbymorrison self-assigned this Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design design / style issue
Projects
None yet
Development

No branches or pull requests

2 participants