-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC-0047: Unified User Agent #141
base: master
Are you sure you want to change the base?
Conversation
| ------------- | ---------- | | ||
| .NET | `dotnet` | | ||
| C++ | `cxx` | | ||
| Go | `golang` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chvck Should we split this to gocb
and gocbcore
which more closely aligns with what gocb/gocbcore currently do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Go | `golang` | | |
| Go | `gocb` | | |
| Go Core | `gocbcore` | |
| Scala | `scala` | | ||
| Kafka | `kafka` | | ||
| ElasticSearch | `es` | | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Java Columnar | `couchbase-java-columnar` | | |
| Node.js Columnar | `nodejs-columnar` | | |
| Python Columnar | `python-columnar` | | |
Seems like we might as well add the Columnar SDKs since we are making an update when they are already in existence.
I don't have a strong opinion, but just to voice it… Seeing things like "java/3.7.5" in the string seem a bit misleading. It's not really "java". I know not many unfamiliar with Couchbase will be looking at this, but it does make be wonder if a couple more characters like "javacb" or "cbjava" disambiguate it better. There may be some collisions that could be confusing. "python/4.1.3" could collide next year with an actual python runtime. If ya'll think I'm being too pedantic, I'm good to go with the suggestions. Also, regarding "couchbase-java-columnar" (23 chars?), the server side is going to use only up to the first 32 characters or a space, whichever comes first, in statistics aggregation (but not logging). so something like "javacbcol" might be better to avoid a git hash or the like being excluded. |
No description provided.