Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-0047: Unified User Agent #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

avsej
Copy link
Member

@avsej avsej commented Nov 11, 2024

No description provided.

@avsej avsej requested a review from a team November 11, 2024 08:59
| ------------- | ---------- |
| .NET | `dotnet` |
| C++ | `cxx` |
| Go | `golang` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chvck Should we split this to gocb and gocbcore which more closely aligns with what gocb/gocbcore currently do?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Go | `golang` |
| Go | `gocb` |
| Go Core | `gocbcore` |

| Scala | `scala` |
| Kafka | `kafka` |
| ElasticSearch | `es` |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| Java Columnar | `couchbase-java-columnar` |
| Node.js Columnar | `nodejs-columnar` |
| Python Columnar | `python-columnar` |

Seems like we might as well add the Columnar SDKs since we are making an update when they are already in existence.

@ingenthr
Copy link
Contributor

I don't have a strong opinion, but just to voice it…

Seeing things like "java/3.7.5" in the string seem a bit misleading. It's not really "java". I know not many unfamiliar with Couchbase will be looking at this, but it does make be wonder if a couple more characters like "javacb" or "cbjava" disambiguate it better. There may be some collisions that could be confusing. "python/4.1.3" could collide next year with an actual python runtime.

If ya'll think I'm being too pedantic, I'm good to go with the suggestions.

Also, regarding "couchbase-java-columnar" (23 chars?), the server side is going to use only up to the first 32 characters or a space, whichever comes first, in statistics aggregation (but not logging). so something like "javacbcol" might be better to avoid a git hash or the like being excluded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants