Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC-0084: Application Telemetry #140

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

RFC-0084: Application Telemetry #140

Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
8527fac
0084-ApplicationTelemetry: Initial Draft
avsej Nov 7, 2024
dca9701
Update RFC in response to the review notes
avsej Nov 20, 2024
3fba8af
Explicitly say that virtual/compound operations must not be tracked
avsej Dec 4, 2024
d6b74b9
Clarify that SDK should wait for `app_telemetry_backoff` when server …
avsej Dec 4, 2024
ca89b90
Remove duplication of histogram buckets definition
avsej Dec 4, 2024
3c9775a
Add the point about sending zero metrics
avsej Dec 4, 2024
5d6dc3b
Clarified histogram value format
avsej Dec 12, 2024
0c159c7
Explicitly note that the server might strip any tags
avsej Dec 12, 2024
a96e713
Relax requirement of the payload for GET_TELEMETRY request
avsej Dec 12, 2024
020ca61
Add not about _r_total
avsej Dec 12, 2024
22f4a95
update parts about services the SDK should report
avsej Dec 12, 2024
e5e6ea7
Add note that values of metrics must be integers
avsej Dec 12, 2024
c28b266
make it clear that histogram buckets are string literals
avsej Dec 12, 2024
b3ace08
Remove id from the metric labels
avsej Jan 14, 2025
3c3f912
Update the configuration key in Cluster Configuration JSON
avsej Jan 17, 2025
6b16682
Update according to recent discussions
avsej Jan 20, 2025
159c3a3
add eventings into histogram table
avsej Feb 3, 2025
0ab54b8
restore alt_node label
avsej Feb 3, 2025
5ddaa6e
Update statement about metrics and histogram bucket with zero values
avsej Feb 3, 2025
4070a35
declare options for PING: deadline and interval
avsej Feb 3, 2025
5276a96
update timestamps of the examples to milliseconds resolution
avsej Feb 3, 2025
2ea2c8b
Note that the SDK must not collect the metrics if the feature disable…
avsej Feb 3, 2025
b3f866d
Remove timestamps from the samples
avsej Feb 3, 2025
ae26b47
use milliseconds for histograms to avoid rounding and floats
avsej Feb 3, 2025
daa6c7f
Explicitly say that transactions will be visible as unrelated subdoc …
avsej Feb 3, 2025
3195d36
Add rule to decide which histogram for KV to use for given opcode
avsej Feb 3, 2025
76d1b0e
clarify why _total might differ from histogram _count
avsej Feb 3, 2025
961165e
update histogram "le" labels to milliseconds
avsej Feb 3, 2025
e89879f
fix le="0.001" in the explanation of the labels
avsej Feb 3, 2025
7e1502b
remove note about ParseFloat for _sum of histogram
avsej Feb 3, 2025
03c3eca
Declare app_telemetry_ping_interval to be 30 seconds
avsej Feb 3, 2025
ee576e6
rename duration_ms to duration_milliseconds
avsej Feb 5, 2025
f44aabb
define histogram for management API
avsej Feb 5, 2025
7658e6f
Enumerate services for counters
avsej Feb 7, 2025
809bdf1
Rename app_telemetry_ping_deadline -> app_telemetry_ping_timeout
avsej Feb 8, 2025
2db1e5e
Mark alt_node label as optional
avsej Feb 11, 2025
0f1ce6a
Add a note about labels for operations that timing out before receivi…
avsej Feb 11, 2025
a24b2f7
Clarify classification of mutation/retrieval operations of KV
avsej Feb 13, 2025
1fabad7
Note that it is the server should filter the empty-node_uuid metrics
avsej Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading