Remove the aspect-ratio directive from .embed-video CSS class
#2134
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all video is in 16:9 aspect ratio (e.g., vertical video), and forcing that causes the videos to appear small with large black spaces on either side. Signed-off-by: Sean Whalen <44679+seanthegeek@users.noreply.github.com>
cotes2020
reviewed
Dec 22, 2024
There was a problem hiding this comment.
This is a good point. When designing, I envisioned embedded videos to be in landscape mode, so a 16:9 aspect ratio is sufficient. In the future, a new parameter might be introduced to accept custom classes to accommodate the aspect ratio of short videos.
However, simply removing the original 16:9 aspect ratio in your modification is not advisable, as it will break the existing functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Not all video is in 16:9 aspect ratio (e.g., vertical video), and forcing that causes the videos to appear small with large black spaces on either side.