Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bilibili support #1406

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Conversation

mill413
Copy link
Contributor

@mill413 mill413 commented Dec 4, 2023

Type of change

  • New feature (non-breaking change which adds functionality)

Description

Add embed bilibili video template in _includes/embed/bilibili.html like YouTube or twitch

Additional context

Copy link
Owner

@cotes2020 cotes2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR

_includes/embed/bilibili.html Outdated Show resolved Hide resolved
@mill413
Copy link
Contributor Author

mill413 commented Dec 5, 2023

I found that class is still youtube so I changed it. And add code in ./sass/addon/commons.scss instead of unused height and width to make it look better.

_sass/addon/commons.scss Outdated Show resolved Hide resolved
@cotes2020 cotes2020 force-pushed the add-bilibili-support branch from 322208d to 6bea14e Compare December 9, 2023 13:41
@cotes2020 cotes2020 merged commit 4a2b89d into cotes2020:master Dec 9, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants