chore: upgrade rate-limiting to ibc-go v10 #234
+876
−675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wllmshao
changed the title
wllmshao
force-pushed
the
ws/rate_limit_ibcv10
branch
from
42cef65 to
2a4c7e7
Compare
wllmshao
force-pushed
the
ws/rate_limit_ibcv10
branch
from
8e9f34d to
6567a34
Compare
wllmshao
force-pushed
the
ws/rate_limit_ibcv10
branch
from
6567a34 to
cfc34a7
Compare
Eric-Warehime
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Let's work on cleaning this up after we get a release candidate cut. I think the ibc team is going to replace some of these and for the others we should move to using the Denom type.
There was a problem hiding this comment.
LGTM but I definitely think we need to test more before full release.
|
Also looks like some of the checks are failing because of #226 I think we can probably get that fixed pretty easily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rate-limiting/v2, which implements anIBCMiddlewarethat implementsgithub.com/cosmos/ibc-go/v10/modules/core/api/IBCModule