Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mesh_segment_by_path silently drops mesh faces #23

Open
cornelmpop opened this issue Feb 15, 2024 · 0 comments
Open

mesh_segment_by_path silently drops mesh faces #23

cornelmpop opened this issue Feb 15, 2024 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@cornelmpop
Copy link
Owner

cornelmpop commented Feb 15, 2024

The function drops some faces that clearly should not be dropped. A reproducible example:

mesh <- demoSphere
pois <- t(demoSphere$vb)[c(1, 20, 30, 45), 1:3]
mesh_path <- sPathConnect(pois, mesh, closed = TRUE)
res <- mesh_segment_by_path(mesh, mesh.path = mesh_path)

#' No purple face from the un-split mesh should be visible, but one is because the split
#' mesh segments don't cover the whole surface (i.e., a face was dropped)
shade3d(mesh, col = "purple", alpha = 0.9)
shade3d(res[[1]], col = "red")
shade3d(res[[2]], col = "green")

@cornelmpop cornelmpop added the bug Something isn't working label Feb 15, 2024
@cornelmpop cornelmpop added this to the 0.6.0 milestone Feb 15, 2024
@cornelmpop cornelmpop self-assigned this Feb 15, 2024
cornelmpop added a commit that referenced this issue Feb 17, 2024
…(see issue #23). Also cleaned the code a bit, made some minor changes to the function's documentation, and added tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant