Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devex: use dotenv #2

Merged
merged 1 commit into from
Oct 23, 2024
Merged

devex: use dotenv #2

merged 1 commit into from
Oct 23, 2024

Conversation

tomholford
Copy link
Contributor

This change allows a user to optionally use a local .env file to load the API key and updates the README's setup instructions.

@tomholford tomholford marked this pull request as ready for review October 23, 2024 18:00
corbt
corbt approved these changes Oct 23, 2024
View reviewed changes
Copy link
Owner

@corbt corbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, works for me! A better solution would be to prompt the user for the API key on startup and let them change it on a settings screen but probably not worth the investment at this point. :)

@corbt corbt merged commit 59a6c7e into corbt:main Oct 23, 2024
1 of 3 checks passed
@tomholford tomholford deleted the th/dotenv branch October 25, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corbt corbt corbt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomholford @corbt