Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring protofetch with a config file #120

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

rtimush
Copy link
Collaborator

@rtimush rtimush commented Nov 2, 2023

This will be especially useful after #119 lands, users will be able to configure default git protocol in the config file.

dirs says that on macOS config files should be in /Users/Alice/Library/Application Support, which I'm not sure about. I guess it follows the guidelines, but for CLI tools it's probably more common to use /Users/Alice/.config. Would be nice to hear your thoughts.

Closes #31

@rtimush rtimush requested a review from a team November 2, 2023 16:28
@RafalSumislawski
Copy link
Member

I'm for the /Users/Alice/.config option. That's what I'm used to on Mac/Linux.

@rtimush
Copy link
Collaborator Author

rtimush commented Nov 3, 2023

Updated to use ~/.config/protofetch on all platforms.

@rtimush rtimush merged commit e045273 into master Nov 3, 2023
12 checks passed
@rtimush rtimush deleted the config-file branch November 3, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create config file .protofetch
2 participants