Adapt to Coq PR #18591: better refolding of addn induces now useless addnE #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…addnE. "simpl" was missing some refoldings. Coq PR #18591 fixes it. As a result, a rewriting from Nat.add to addn becomes useless. We keep it optional though for compatibility.
2 tasks
|
Subsumed by #58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tactic
simplwas missing some refoldings that Coq's PR coq/coq#18591 fixes. As a result, a rewriting fromNat.addtoaddnbecomes useless. We keep it optional though for compatibility (though I did not double-check the compilation myself). If correctly backwards-compatible, it can be merged as soon as now.