fix: propagate error if issue with polling

client/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "cooklang-sync-client"
-version = "0.2.4"
+version = "0.2.5"
 authors = ["Alexey Dubovskoy <alexey@cooklang.org>"]
 edition = "2021"
 description = "A client library for cooklang-sync"

client/src/lib.rs

@@ -80,10 +80,9 @@ pub fn run(
 #[uniffi::export]
 pub fn wait_remote_update(
     api_endpoint: &str,
-    remote_token: &str,
-    wait_time: u64,
+    remote_token: &str
 ) -> Result<(), errors::SyncError> {
-    Runtime::new()?.block_on(remote::Remote::new(api_endpoint, remote_token).poll(wait_time))?;
+    Runtime::new()?.block_on(remote::Remote::new(api_endpoint, remote_token).poll())?;
 
     Ok(())
 }

client/src/remote.rs

@@ -182,9 +182,12 @@ impl Remote {
         }
     }
 
-    pub async fn poll(&self, seconds: u64) -> Result<()> {
+    pub async fn poll(&self) -> Result<()> {
         trace!("started poll");
 
+        // setting its larger than the request timeout to avoid timeouts from the server
+        let seconds = REQUEST_TIMEOUT_SECS + 10;
+
         let seconds_string = seconds.to_string();
 
         let response = self
@@ -205,8 +208,7 @@ impl Remote {
             Ok(response) => match response.status() {
                 StatusCode::OK => Ok(()),
                 StatusCode::UNAUTHORIZED => Err(SyncError::Unauthorized),
-                // Don't need to error as it's expected to be cancelled from time to time
-                _ => Ok(()),
+                _ => Err(SyncError::Unknown),
             },
             Err(e) if e.is_timeout() => Ok(()), // Ignore timeout errors
             Err(e) => Err(e.into()),

client/src/syncer.rs

@@ -13,7 +13,7 @@ use crate::connection::{get_connection, ConnectionPool};
 use crate::errors::SyncError;
 use crate::models;
 use crate::registry;
-use crate::remote::{CommitResultStatus, Remote, REQUEST_TIMEOUT_SECS};
+use crate::remote::{CommitResultStatus, Remote};
 
 type Result<T, E = SyncError> = std::result::Result<T, E>;
 
@@ -86,7 +86,7 @@ async fn download_loop(
 
         // need to be longer than request timeout to make sure we don't get
         // client side timeout error
-        remote.poll(REQUEST_TIMEOUT_SECS + 10).await?;
+        remote.poll().await?;
     }
 }