Fix: Bad variable for creating directory and checking is_writable() i…

…n getNoImage() method
contributte · Apr 29, 2020 · edac889 · edac889
1 parent adf95a7
commit edac889
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/ImageStorage.php b/src/ImageStorage.php
@@ -253,13 +253,13 @@ public function getNoImage(bool $return_image = false): Image
 			$new_path = sprintf('%s/%s', $this->data_path, $identifier);
 
 			if (!file_exists($new_path)) {
-				$dirName = dirname($identifier);
+				$dirName = dirname($new_path);
 
 				if (!file_exists($dirName)) {
 					mkdir($dirName, 0777, true);
 				}
 
-				if (!file_exists($dirName) || !is_writable($new_path)) {
+				if (!file_exists($dirName) || !is_writable($dirName)) {
 					throw new ImageStorageException('Could not create default no_image.png. ' . $dirName . ' does not exist or is not writable.');
 				}