Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JSON schema issue with gemini tool calls #3851

Merged
merged 4 commits into from
Feb 1, 2025
Merged

fix: JSON schema issue with gemini tool calls #3851

merged 4 commits into from
Feb 1, 2025

Conversation

monotykamary
Copy link
Contributor

Description

Fixes tool calling error that happens when using Gemini. Not actually sure if it's because of MCP servers, but at least now it works.

Checklist

  • Fixed and added JSON schema cleaning for processing tools with Gemini

Screenshots

image

Testing instructions

Select any Gemini model and enable tools. Prompt it in such a way that it will invoke the tool and see the results.

@monotykamary
fix: gemini tool calls with MCP

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
9ca4ad4
@netlify Netlify
Copy link

netlify bot commented Jan 26, 2025 •
edited
Loading

✅ Deploy Preview for continuedev ready!

Name Link
🔨 Latest commit 7ce1943
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/679d5c7ae092970008afa19b
😎 Deploy Preview https://deploy-preview-3851--continuedev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sestinj sestinj requested a review from RomneyDa January 27, 2025 21:31
RomneyDa
RomneyDa requested changes Jan 28, 2025
View reviewed changes
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:24 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:25 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 30, 2025 18:27 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:27 — with GitHub Actions Inactive
@RomneyDa
Copy link
Collaborator

Note, have pulled branch and tested, works great.
Will merge today,

@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:28 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@RomneyDa RomneyDa temporarily deployed to tests-requiring-secrets January 31, 2025 23:30 — with GitHub Actions Inactive
@sestinj sestinj merged commit 7220b49 into continuedev:main Feb 1, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomneyDa RomneyDa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@monotykamary @RomneyDa @sestinj