Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GlobalStyles): improve lowercase L (l) and uppercase i (I) readability #2995

Merged
merged 4 commits into from
Feb 14, 2025

Conversation

cf-remylenoir
Copy link
Collaborator

@cf-remylenoir cf-remylenoir commented Feb 14, 2025

Purpose of PR

Improves lowercase L (l) and uppercase i (I) readability.

See the Paragraph story: https://5fd1dda724cc620021ace8c5-bvjnlbvdkg.chromatic.com/?path=/story/typography-paragraph--basic

Before After
Screenshot 2025-02-14 at 13 55 58 Screenshot 2025-02-14 at 13 56 17

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

@cf-remylenoir cf-remylenoir self-assigned this Feb 14, 2025
Copy link

changeset-bot bot commented Feb 14, 2025

🦋 Changeset detected

Latest commit: 0b7c748

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@contentful/f36-core Patch
@contentful/f36-typography Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-badge Patch
@contentful/f36-button Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-entity-list Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-header Patch
@contentful/f36-list Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-navbar Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-tooltip Patch
@contentful/f36-components Patch
@contentful/f36-image Patch
@contentful/f36-avatar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Feb 14, 2025 1:33pm
forma-36-website ❌ Failed (Inspect) Feb 14, 2025 1:33pm

@cf-remylenoir cf-remylenoir changed the title feat(GlobalStyles): add CSS rule to improve readability of lowercase l (L) and capital i (I) feat(GlobalStyles): add CSS rule to improve readability of lowercase L (l) and capital i (I) Feb 14, 2025
@cf-remylenoir cf-remylenoir changed the title feat(GlobalStyles): add CSS rule to improve readability of lowercase L (l) and capital i (I) feat(GlobalStyles): add CSS rule to improve readability of lowercase L (l) and uppercase i (I) Feb 14, 2025
@cf-remylenoir cf-remylenoir changed the title feat(GlobalStyles): add CSS rule to improve readability of lowercase L (l) and uppercase i (I) feat(GlobalStyles): improve readability of lowercase L (l) and uppercase i (I) Feb 14, 2025
@cf-remylenoir cf-remylenoir changed the title feat(GlobalStyles): improve readability of lowercase L (l) and uppercase i (I) feat(GlobalStyles): improve lowercase L (l) and uppercase i (I) readability Feb 14, 2025
Copy link

github-actions bot commented Feb 14, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 113.52 KB (-0.07% 🔽) 2.3 s (-0.07% 🔽) 1.5 s (+9.51% 🔺) 3.8 s
Module 112.08 KB (+0.02% 🔺) 2.3 s (+0.02% 🔺) 1.6 s (-6.15% 🔽) 3.8 s

Copy link
Contributor

@roosterhack roosterhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@cf-remylenoir cf-remylenoir merged commit 50b070e into main Feb 14, 2025
18 of 19 checks passed
@cf-remylenoir cf-remylenoir deleted the UFO-1655-css-rule-for-capital-i-in-ai branch February 14, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants