Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace the Storybook asset #2981

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

cf-remylenoir
Copy link
Collaborator

@cf-remylenoir cf-remylenoir commented Jan 20, 2025

Purpose of PR

The asset used in our stories started to get false positives in Chromatic, this is due to anti-aliasing and very likely to complex areas in the asset (areas with a lot of complexity, colors, or shadows).

Screenshot 2025-01-20 at 17 03 03

This is an attempt to use an asset with less noise which should decrease the false-positives.

Note: I explored the diffThreshold property used to control the accuracy but its default value (.063) is already optimized (0 is the most accurate, 1 is less accurate).

Before After

@cf-remylenoir cf-remylenoir self-assigned this Jan 20, 2025
Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: aaa6c42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Jan 20, 2025 3:54pm

Copy link

github-actions bot commented Jan 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 112.39 KB (0%) 2.3 s (0%) 346 ms (+40.02% 🔺) 2.6 s
Module 110.99 KB (0%) 2.3 s (0%) 309 ms (+7.59% 🔺) 2.6 s

@cf-remylenoir cf-remylenoir marked this pull request as ready for review January 20, 2025 16:00
@cf-remylenoir cf-remylenoir requested review from damann and a team as code owners January 20, 2025 16:00
@cf-remylenoir cf-remylenoir merged commit deecf10 into main Jan 21, 2025
17 checks passed
@cf-remylenoir cf-remylenoir deleted the refactor-replace-storybook-asset branch January 21, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants