initContainer: also create mount points for sockets #1576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a socket is bind-mounted to the container, also create a file mount point for it. Nvidia CDI on the proprietary driver added a socket for `nvidia-persistence.service` which was failing to be mounted in the container as no mount point existed. More logs in the issue below. Fixes containers#1572
debarshiray
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Thanks for the patch @jbtrystram ! This looks correct to me. However, I am about to leave for an extended weekend, so I am not in a position to test it. I will get it merged once I am back on Tuesday.
Thanks again!
debarshiray
reviewed
Oct 29, 2024
There was a problem hiding this comment.
It works perfectly in my testing! Thanks!
Oddly, I can't force push after rebasing against main:
$ git push --force jbtrystram mount_nvidia_peristence_socket:jbtrystram/mount_nvidia_peristence_socket
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 16 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 847 bytes | 847.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0), pack-reused 0 (from 0)
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
To github.com:jbtrystram/ctrs-toolbox.git
! [remote rejected] mount_nvidia_peristence_socket -> jbtrystram/mount_nvidia_peristence_socket (permission denied)
error: failed to push some refs to 'github.com:jbtrystram/ctrs-toolbox.git'
... so, I pushed it to #1577
Waiting for the CI to finish.
|
Weird. I'll close this then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a socket is bind-mounted to the container, also create a file mount point for it. Nvidia CDI on the proprietary driver added a socket for
nvidia-persistence.servicewhich was failing to be mounted in the container as no mount point existed.More logs in the issue below.
Fixes #1572