improve the name of var partition #740

pengshanyu · 2025-03-03T06:53:01Z

Resolve: #722

Summary by Sourcery

Tests:

Improve the logic to detect the /var partition in the test script.

sourcery-ai · 2025-03-03T06:53:06Z

Reviewer's Guide by Sourcery

This pull request improves the check_var_partition function in tests/ffi/disk/test.sh by introducing a variable for the partition name, adding a condition for CentOS, and moving debugging commands to improve the detection of the /var partition.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change	Details	Files
Improved the logic to detect the /var partition by introducing a variable for the partition name and adding a condition for CentOS.	Introduced the `var_partition_name` variable to store the partition name. Modified the conditional logic to use `var_partition_name` instead of `qm_var_partition`. Added a condition to set `var_partition_name` specifically for CentOS based on the OS release ID.	`tests/ffi/disk/test.sh`
Moved `lsblk` and `df -kh` commands before the conditional check for the /var partition.	Moved `lsblk` and `df -kh` commands to execute before the conditional check to aid in debugging.	`tests/ffi/disk/test.sh`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!
Generate a plan of action for an issue: Comment @sourcery-ai plan on
an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey @pengshanyu - I've reviewed your changes - here's some feedback:

Overall Comments:

Consider using more descriptive variable names than var_partition_name to improve readability.
The lsblk and df -kh commands are helpful for debugging, but should be removed before merging.

Here's what I looked at during the review

🟢 General issues: all looks good
🟢 Security: all looks good
🟢 Testing: all looks good
🟢 Complexity: all looks good
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

tests/ffi/disk/test.sh

pengshanyu · 2025-03-05T14:02:52Z

I'm not sure why there are failures of SRPM build failed/copying system image from manifest list: parsing image configuration: fetching blob: received unexpected HTTP status: 502 Bad Gateway INFO: Pulling image: registry.fedoraproject.org/fedora:41
Hi @Yarboa @dougsland , could you help to take a look, thanks.

Yarboa · 2025-03-05T15:57:33Z

Please refer that, I assume it will be online soon
b'Trying to pull registry.fedoraproject.org/fedora:41...\nError: copying system image from manifest list: parsing image configuration: fetching blob: received unexpected HTTP status: 502 Bad Gateway\n'
INFO: Pulling image: registry.fedoraproject.org/fedora:41

Yarboa · 2025-03-05T16:03:33Z

tests/ffi/disk/test.sh

@@ -5,17 +5,29 @@
 . ../common/prepare.sh

 check_var_partition(){
+   name_of_qm_var_partition="part /var/qm"
+   seccomp_file_name="/usr/share/qm/seccomp.json"


Consider querying it only if it exist in PodmanArgs.
In case no PodmanArgs, at all, I assume you should use container Memory instead

Yarboa · 2025-03-05T16:05:27Z

tests/ffi/disk/test.sh

@@ -33,18 +45,14 @@ OOMScoreAdjust=1000

 [Container]
 PodmanArgs=
-PodmanArgs=--pids-limit=-1 --security-opt seccomp=/usr/share/qm/seccomp-no-rt.json --security-opt label=nested --security-opt unmask=all --memory 5G
+PodmanArgs=--pids-limit=-1 --security-opt seccomp=${seccomp_file_name} --security-opt label=nested --security-opt unmask=all --memory 5G


In case there is not PodmanArgs, see above
You should only use Memory

Signed-off-by: pengshanyu <yupengshan@hotmail.com> improve oom.conf;improve variable names improve PodmanArgs

pengshanyu requested review from rhatdan, lsm5, dougsland, Yarboa, sandrobonazzola, nsednev, aesteve-rh and kleinffm as code owners March 3, 2025 06:53

sourcery-ai bot reviewed Mar 3, 2025

View reviewed changes

Yarboa reviewed Mar 3, 2025

View reviewed changes

tests/ffi/disk/test.sh Show resolved Hide resolved

pengshanyu force-pushed the improve-disk branch from c72d172 to 316f91b Compare March 5, 2025 07:25

pengshanyu changed the title ~~draft: improve the name of var partition~~ improve the name of var partition Mar 5, 2025

pengshanyu mentioned this pull request Mar 5, 2025

improve /ffi/disk test #722

Open

Yarboa reviewed Mar 5, 2025

View reviewed changes

improve the name of var partition

6558b5b

Signed-off-by: pengshanyu <yupengshan@hotmail.com> improve oom.conf;improve variable names improve PodmanArgs

pengshanyu force-pushed the improve-disk branch from 3656478 to 6558b5b Compare March 6, 2025 06:12

Yarboa mentioned this pull request Mar 6, 2025

CI/CD checks fails on agent-flood. #721

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improve the name of var partition #740

improve the name of var partition #740

pengshanyu commented Mar 3, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Mar 3, 2025 •

edited

Loading

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

pengshanyu commented Mar 5, 2025

Yarboa commented Mar 5, 2025

Yarboa Mar 5, 2025

pengshanyu Mar 6, 2025

Yarboa Mar 5, 2025

pengshanyu Mar 6, 2025

improve the name of var partition #740

Are you sure you want to change the base?

improve the name of var partition #740

Conversation

pengshanyu commented Mar 3, 2025 • edited by sourcery-ai bot Loading

Summary by Sourcery

sourcery-ai bot commented Mar 3, 2025 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

sourcery-ai bot left a comment

Choose a reason for hiding this comment

pengshanyu commented Mar 5, 2025

Yarboa commented Mar 5, 2025

Yarboa Mar 5, 2025

Choose a reason for hiding this comment

pengshanyu Mar 6, 2025

Choose a reason for hiding this comment

Yarboa Mar 5, 2025

Choose a reason for hiding this comment

pengshanyu Mar 6, 2025

Choose a reason for hiding this comment

pengshanyu commented Mar 3, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Mar 3, 2025 •

edited

Loading