Is MatchesResult useless code?

[BlackHole1]

I would like to understand why this PR (#1914) was not merged, while the closed PR depended on the upstream PR (containers/storage#446). Moreover, the upstream PR (containers/storage#446) has been merged, but the current situation resulted in the new function introduced in the PR (containers/storage#446) not being utilized throughout the entire containers repository.

In containers/storage#446, the Matches function has been added with a Deprecated comment. See: https://github.com/containers/storage/blob/8730e29911b3d1fc3122e8dca399782a138854e5/pkg/fileutils/fileutils.go#L60

/cc @saschagrunert @rhatdan @vrothberg

[vrothberg]

@flouthoc @nalind PTAL

[BlackHole1]

I'm currently in an uncomfortable situation because I noticed that the Matches function has been deprecated. As a result, all my changes were based on the MatchesResult function. After I finished modifying everything, I suddenly realized that none of the repositories under the "containers" organization were using this function except for an unmerged pull request. 🤣

[BlackHole1]

Close this discussion. See: containers/storage#1656 (comment)