Skip to content

Commit

Permalink
Fixed stylelint configuration (#405)
Browse files Browse the repository at this point in the history
* fixed stylelint configuration

* bumped packages: design-tokens, service-pages

* updated CHANGELOG: design-tokens, service-pages

---------

Co-authored-by: Gabriele Borelli <gabriele.borelli@contactlab.com>
  • Loading branch information
gabrieleborelli and Gabriele Borelli authored Nov 26, 2024
1 parent 1568e15 commit f78f1f4
Show file tree
Hide file tree
Showing 8 changed files with 49 additions and 86 deletions.
4 changes: 2 additions & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"editor.formatOnSave": true,
"editor.codeActionsOnSave": {
"source.fixAll.eslint": true,
"source.fixAll.stylelint": true
"source.fixAll.eslint": "always",
"source.fixAll.stylelint": "always"
},
"css.validate": false,
"stylelint.validate": ["css", "scss"],
Expand Down
91 changes: 17 additions & 74 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 10 additions & 3 deletions packages/design-tokens/.stylelintrc.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
{
"extends": [
"@contactlab/stylelint-config",
"@detra-lab/stylelint-config/sass"
"extends": ["@contactlab/stylelint-config"],
"customSyntax": "postcss-scss",
"plugins": [
"stylelint-scss",
"stylelint-declaration-block-no-ignored-properties"
],
"rules": {
"color-function-notation": "legacy",
"font-weight-notation": ["numeric", {"ignore": ["relative"]}],
"function-no-unknown": null,
"no-duplicate-selectors": null,
"plugin/declaration-block-no-ignored-properties": true,
"property-no-unknown": null,
"scss/function-no-unknown": [true, {"ignoreFunctions": ["colors"]}],
"scss/operator-no-unspaced": null
}
}
4 changes: 4 additions & 0 deletions packages/design-tokens/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 3.4.1

- Fixed stylelint configuration

## 3.4.0

- Replace Marketing Cloud with MailUp CDP
Expand Down
6 changes: 4 additions & 2 deletions packages/design-tokens/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@contactlab/ds-tokens",
"version": "3.4.0",
"version": "3.4.1",
"description": "Named entities that store visual-design info, in order to maintain a scalable, consistent system for user interface development.",
"author": "Contactlab",
"homepage": "https://github.com/contactlab/milky-way#readme",
Expand Down Expand Up @@ -29,14 +29,16 @@
},
"devDependencies": {
"@contactlab/stylelint-config": "1.0.0",
"@detra-lab/stylelint-config": "0.1.0",
"eslint": "8.47.0",
"eslint-config-contactlab": "11.2.0",
"eslint-config-prettier": "9.0.0",
"eslint-plugin-react": "7.33.2",
"postcss-scss": "4.0.7",
"postcss-styled-syntax": "0.4.0",
"postcss-syntax": "0.36.2",
"serve": "14.2.0",
"stylelint": "15.10.2",
"stylelint-declaration-block-no-ignored-properties": "2.7.0",
"stylelint-scss": "5.1.0",
"typescript": "5.1.6"
}
Expand Down
8 changes: 5 additions & 3 deletions packages/service-pages/.stylelintrc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"extends": [
"@contactlab/stylelint-config",
"@detra-lab/stylelint-config/sass"
"extends": ["@contactlab/stylelint-config"],
"customSyntax": "postcss-scss",
"plugins": [
"stylelint-scss",
"stylelint-declaration-block-no-ignored-properties"
]
}
4 changes: 4 additions & 0 deletions packages/service-pages/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# Changelog

## 3.2.1

- Fixed stylelint configuration

## 3.2.0

- Replace Marketing Cloud with MailUp CDP
Expand Down
5 changes: 3 additions & 2 deletions packages/service-pages/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@contactlab/service-pages",
"version": "3.2.0",
"version": "3.2.1",
"description": "The MailUp CDP service pages.",
"author": "Contactlab",
"homepage": "https://github.com/contactlab/milky-way#readme",
Expand All @@ -26,7 +26,6 @@
},
"devDependencies": {
"@contactlab/stylelint-config": "1.0.0",
"@detra-lab/stylelint-config": "0.1.0",
"@parcel/config-default": "2.9.3",
"@parcel/transformer-inline-string": "2.9.3",
"@parcel/transformer-pug": "2.9.3",
Expand All @@ -38,6 +37,8 @@
"eslint-plugin-react": "7.33.2",
"parcel": "2.9.3",
"postcss-scss": "4.0.7",
"postcss-styled-syntax": "0.4.0",
"postcss-syntax": "0.36.2",
"stylelint": "15.10.3",
"stylelint-scss": "5.1.0",
"typescript": "5.1.6"
Expand Down

0 comments on commit f78f1f4

Please sign in to comment.