Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node is required to build Conjure Oxide (due to treesitter grammar) #633

Open
niklasdewally opened this issue Feb 3, 2025 · 4 comments
Open
Labels
kind::bug Something isn't working

Comments

@niklasdewally
Copy link
Collaborator

niklasdewally commented Feb 3, 2025

node is required when building treesitter-essence and conjure-oxide from source; however, this is not documented anywhere.

Image

We should either document that node is required, or try to remove it as a dependency.

CC: @ozgurakgun @leiamcalisteryoung

@niklasdewally niklasdewally added the kind::bug Something isn't working label Feb 3, 2025
@TAswan
Copy link
Contributor

TAswan commented Feb 3, 2025

I don't believe it's possible to remove that node dependency without providing tree sitter essence as a binary (unsure how supported that is for js). But would it be worth it to add a compiler flag to ignore tree sitter and only use the legacy parser?

@ozgurakgun
Copy link
Contributor

I think we may be able to avoid this by commiting the generated parser code in the repo. As long as we have an easy way (probably a script?) to regenerate the parser code this might be ok. Though I am not sure of the specifics, and won't be suprised if I am missing something.

My understanding is that tree-sitter-cli requires node and it is only used to generate a bunch of files?

@niklasdewally
Copy link
Collaborator Author

As long as we have an easy way (probably a script?) to regenerate the parser code this might be ok.

We could keep the existing build script, but make it trigger only when the parser code is changed?

@ozgurakgun
Copy link
Contributor

We could keep the existing build script, but make it trigger only when the parser code is changed?

That sounds good. If it's hard to set that up, we can even have it as a manual step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind::bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants