Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: Revert v0.11.0 release-specfic changes back to dev values #468

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Release: Revert v0.11.0 release-specfic changes back to dev values #468

merged 2 commits into from
Nov 27, 2024

Conversation

niteeshkd
Copy link

This reverts the changes done in two commits (related to the kata payloads and enclave-cc payloads) with the PR #465 .

Niteesh Dubey added 2 commits November 26, 2024 15:11
Revert "release: bump enclave-cc runtime payloads for v0.11.0"
206d6f8 
This reverts commit 524eb79.

Signed-off-by: Niteesh Dubey <niteesh@us.ibm.com>
Revert "release: bump kata payloads for v0.11.0"
af5f4e7 
This reverts commit b9ad51e.

Signed-off-by: Niteesh Dubey <niteesh@us.ibm.com>
@niteeshkd niteeshkd requested a review from a team as a code owner November 26, 2024 15:20
stevenhorsman
stevenhorsman approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @niteeshkd!

fitzthum
fitzthum approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fitzthum
Copy link
Member

fitzthum commented Nov 26, 2024 •
edited
Loading

Some test issues

[preflight] Running pre-flight checks
error execution phase preflight: [preflight] Some fatal errors occurred:
	[ERROR KubeletVersion]: the kubelet version is higher than the control plane version. This is not a supported version skew and may lead to a malfunctional cluster. Kubelet version: "1.31.1" Control plane version: "1.30.1"

See #466 (comment)

@ryansavino @AdithyaKrishnan I think we might need to clean up the SEV/SNP node

@wainersm
Copy link
Member

sorry @niteeshkd , I missed the discussion why we are reverting, mind to summarize to me?

@fitzthum
Copy link
Member

I missed the discussion why we are reverting, mind to summarize to me?

step 9 on release checklist. normal procedure but hopefully we didn't get ahead of ourselves

@wainersm
Copy link
Member

I missed the discussion why we are reverting, mind to summarize to me?

step 9 on release checklist. normal procedure but hopefully we didn't get ahead of ourselves

oh, just noticed the 0.10. version is out! hehehe sorry guys!

@fitzthum fitzthum merged commit 15d1721 into confidential-containers:main Nov 27, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenhorsman stevenhorsman stevenhorsman approved these changes

@fitzthum fitzthum fitzthum approved these changes

@wainersm wainersm wainersm approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niteeshkd @fitzthum @wainersm @stevenhorsman