Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove INSTALL-CC-WITH-IBM-SE.md #444

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

BbolroC
Copy link
Member

@BbolroC BbolroC commented Sep 16, 2024

As the documentation has been migrated to the confidential-containers repo, (see confidential-containers/confidential-containers#241) this commit removes the migrated installation guide for IBM SE.

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

@BbolroC BbolroC requested a review from a team as a code owner September 16, 2024 10:48
@BbolroC BbolroC added documentation Improvements or additions to documentation ok-to-test labels Sep 16, 2024
Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BbolroC BbolroC force-pushed the remove-how-to-ibm-se branch 2 times, most recently from 794de6b to 3548912 Compare September 17, 2024 19:48
@BbolroC
Copy link
Member Author

BbolroC commented Sep 17, 2024

Copy link
Contributor

@ldoktor ldoktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, lgtm

@BbolroC
Copy link
Member Author

BbolroC commented Sep 18, 2024

I was wondering why 2 pending jobs are not picked by a runner.

@stevenhorsman
Copy link
Member

I was wondering why 2 pending jobs are not picked by a runner.

Yeah, I'll try closing and re-opening the PR. I saw this on kata yesterday too, so maybe there was a github blip?

@ldoktor
Copy link
Contributor

ldoktor commented Sep 19, 2024

Well it's not a blip, it's because the ccruntime e2e tests for PR have paths-ignore: docs/**... Which is logical, but stock github requirements do not cope with that.

@ldoktor
Copy link
Contributor

ldoktor commented Sep 19, 2024

... perhaps the operator needs something like kata-containers/kata-containers#9637 as well ;-)

@stevenhorsman
Copy link
Member

... perhaps the operator needs something like kata-containers/kata-containers#9637 as well ;-)

Yes, I didn't realise we had that skip here as well as in kata (which we had to remove as it forced us to admin push PRs like this.

As INSTALL-CC-WITH-IBM-SE.md has been migrated to
https://github.com/confidential-containers/confidential-containers/blob/main/guides/ibm-se.md,
this commit updates the link in INSTALL.md accordingly.

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
As the documentation has been migrated to the confidential-containers repo,
(see confidential-containers/confidential-containers#241)
this commit removes the migrated installation guide for IBM SE.

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC BbolroC force-pushed the remove-how-to-ibm-se branch from 3548912 to 96d730b Compare September 25, 2024 16:15
@BbolroC BbolroC merged commit a00c882 into confidential-containers:main Sep 25, 2024
16 of 18 checks passed
@BbolroC BbolroC deleted the remove-how-to-ibm-se branch September 25, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants