-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Remove INSTALL-CC-WITH-IBM-SE.md #444
docs: Remove INSTALL-CC-WITH-IBM-SE.md #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also modify the https://github.com/confidential-containers/operator/blob/main/docs/INSTALL.md?plain=1#L173 link to point to https://github.com/confidential-containers/confidential-containers/blob/main/guides/ibm-se.md ?
794de6b
to
3548912
Compare
Thanks for the catch. The PR has been updated. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, lgtm
I was wondering why 2 pending jobs are not picked by a runner. |
Yeah, I'll try closing and re-opening the PR. I saw this on kata yesterday too, so maybe there was a github blip? |
Well it's not a blip, it's because the |
... perhaps the operator needs something like kata-containers/kata-containers#9637 as well ;-) |
Yes, I didn't realise we had that skip here as well as in kata (which we had to remove as it forced us to admin push PRs like this. |
As INSTALL-CC-WITH-IBM-SE.md has been migrated to https://github.com/confidential-containers/confidential-containers/blob/main/guides/ibm-se.md, this commit updates the link in INSTALL.md accordingly. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
As the documentation has been migrated to the confidential-containers repo, (see confidential-containers/confidential-containers#241) this commit removes the migrated installation guide for IBM SE. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
3548912
to
96d730b
Compare
As the documentation has been migrated to the confidential-containers repo, (see confidential-containers/confidential-containers#241) this commit removes the migrated installation guide for IBM SE.
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com