-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GHA: Change label from s390x to s390x-large #408
GHA: Change label from s390x to s390x-large #408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and I can see the labels are also updated, let me merge this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the instance is used in RUNNING_INSTANCE
so that part needs to be addressed. Sorry for acking this a bit too quickly...
Also I grepped for the s390x and couldn't find any other uses, where exactly will the pure s390x
machine tag be used?
Recently, an additional s390x runner was added to the organization. However, it is insufficient for running the operator e2e tests and will function as a supplementary builder. This commit changes the label for the platform from s390x to s390x-large to differentiate this runner. Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
d764eb6
to
e7b3904
Compare
Good catch, by the way. I appreciate it. Let me explain in an easy way: 2 runners for s390x are registered to the organization like:
A runner (2 runners) labeled with |
Thanks, so IIUC it's not used in this repository, but you want to keep the tags in sync with the other repositories under this organization? That sounds reasonable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this should treat all the places.
Recently, an additional s390x runner was added to the organization. However, it is insufficient for running the operator e2e tests and will function as a supplementary builder.
This commit changes the label for the platform from s390x to s390x-large to differentiate the existing runner.
Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com