Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Run the e2e tests on TDX #383

Merged
merged 2 commits into from
Jun 6, 2024
Merged

ci: Run the e2e tests on TDX #383

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c72659f
ci: Stop testing with "kata-clh" for now
fidencio Jun 5, 2024
0258d49
ci: Add support for testing on a TDX machine
fidencio Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ccruntime_e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,13 @@ jobs:
- "az-ubuntu-2004"
- "az-ubuntu-2204"
- "s390x"
- "tdx"
exclude:
- runtimeclass: "kata-qemu"
instance: "tdx"
include:
- runtimeclass: "kata-qemu-tdx"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I don't think the runtimeclass is actually used in the operator tests at the moment, but that doesn't mean we shouldn't have this code change, I just wanted to flag it up

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch.
@wainersm, do you plan to address this at some point soon?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because we only have an install and uninstall test at the moment, which isn't runtime class unique? I expect that when we add some e2e tests we'd be using the runtimeclass for them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the install/uninstall tests don't use the runtimeclass but the operator.sh does check that the expected runtimeclass was installed: https://github.com/confidential-containers/operator/blob/main/tests/e2e/operator.sh#L150

Maybe that check should live in the tests for the sake of clarity?

instance: "tdx"
runs-on: ${{ matrix.instance }}
steps:
- name: Take a pre-action for self-hosted runner
Expand Down
1 change: 1 addition & 0 deletions docs/DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ The following jobs will check for regessions on the default CcRuntime:
|e2e-pr / operator tests (kata-qemu, s390x) | Non-TEE | Ubuntu 22.04 (s390x) | QEMU |
|e2e-pr / operator tests (kata-qemu, az-ubuntu-2004) | Non-TEE | Ubuntu 20.04 | QEMU |
|e2e-pr / operator tests (kata-qemu, az-ubuntu-2204) | Non-TEE | Ubuntu 22.04 | QEMU |
|e2e-pr / operator tests (kata-qemu-tdx, tdx) | TDX | Ubuntu 24.04 | QEMU |

Additionally the following jobs will check regressions on the enclave-cc CcRuntime:

Expand Down
Loading