ci: Run the e2e tests on TDX #383
Conversation
fidencio
force-pushed
the
topic/add-tdx-ci
branch
from
a8dc399 to
4138c98
Compare
Unless someone opposes to that, I'd like to propose we stop testing with Cloud Hypervisor for now, as it still doesn't have TEE support. At the moment TEE support is added, we get back to testing it. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
For the TDX machine we're mostly interested on testing whatever will be tested with the kata-qemu-tdx runtime class, instead of the kata-qemu one. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
fidencio
force-pushed
the
topic/add-tdx-ci
branch
from
4138c98 to
0258d49
Compare
| - runtimeclass: "kata-qemu" | ||
| instance: "tdx" | ||
| include: | ||
| - runtimeclass: "kata-qemu-tdx" |
There was a problem hiding this comment.
FYI I don't think the runtimeclass is actually used in the operator tests at the moment, but that doesn't mean we shouldn't have this code change, I just wanted to flag it up
There was a problem hiding this comment.
Ouch.
@wainersm, do you plan to address this at some point soon?
There was a problem hiding this comment.
I think it's because we only have an install and uninstall test at the moment, which isn't runtime class unique? I expect that when we add some e2e tests we'd be using the runtimeclass for them
There was a problem hiding this comment.
Yes, the install/uninstall tests don't use the runtimeclass but the operator.sh does check that the expected runtimeclass was installed: https://github.com/confidential-containers/operator/blob/main/tests/e2e/operator.sh#L150
Maybe that check should live in the tests for the sake of clarity?
|
|
| @@ -21,14 +21,10 @@ jobs: | |||
| matrix: | |||
| runtimeclass: | |||
| - "kata-qemu" | |||
| - "kata-clh" | |||
Please, see each commit message for more details.
Although we don't have a TDX machine plugged yet, it'd be good to have this reviewed as the tests won't be able to run before they're merged, as it's relying the
pull_request_targetevent.Once the TDX machine is ready, I'd be fine on having this one merged (after review, of course).