image-rs: Redefine constructions of ImageClient and ImageConfig #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChengyuZhu6
requested review from
sameo,
jiangliu,
arronwy,
lumjjb,
jialez0 and
Xynnn007
as code owners
Xynnn007
reviewed
Dec 22, 2023
I will simultaneously update the variable name within the kata side. |
ImageConfig represents the configuration of an image. Previously, we used the `CC_IMAGE_WORK_DIR` environment variable to set the image work directory, but this was not flexible or reliable enough for different use cases. Now, we provide a `new()` method that takes the image work directory as an argument, and returns an ImageConfig instance with that directory. This way, consumers can customize the image work directory as they need. Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6
force-pushed
the
variable
branch
from
0e68efd to
9c6b093
Compare
ChengyuZhu6
changed the title
ChengyuZhu6
force-pushed
the
variable
branch
9 times, most recently
from
f6c3449 to
be0d122
Compare
ImageClient is a client for image management. It has an associated field ImageConfig that could specify the image work directory. Previously, we created an ImageClient instance with default(), which used the `CC_IMAGE_WORK_DIR` environment variable to set the image work directory. This approach was not flexible or reliable for different scenarios. Now, we offer a new() method that accepts the image work directory as a parameter, and returns an ImageClient instance with an ImageConfig that uses that directory. This way, users can customize the image work directory as they wish. Fixes confidential-containers#415 Signed-off-by: ChengyuZhu6 <chengyu.zhu@intel.com>
ChengyuZhu6
force-pushed
the
variable
branch
from
be0d122 to
49ed163
Compare
jiangliu
approved these changes
Dec 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable guest pulling within the kata-agent, it is imperative to configure
CC_IMAGE_WORK_DIRvariable within kata-agent before call image-rs to pull image. However, the use ofCC_IMAGE_WORK_DIRmay cause confusion in the context of kata-containers. Therefore, we can redefine constructions ofImageConfigandImageClientthat accept the image work directory as a parameter and construct instances ofImageConfigandImageClient.Fixes #415