Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kneebow package #28770

Closed
wants to merge 4 commits into from
Closed

Conversation

jaidevjoshi83
Copy link
Contributor

Checklist

  • [x ] Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [x ] License file is packaged (see here for an example).
  • [ x] Source is from official source.
  • [x ] Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • [ x] If static libraries are linked in, the license of the static library is packaged.
  • [x ] Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • [x ] Build number is 0.
  • [x ] A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • [x ] GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • [ x] When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 6, 2025

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/kneebow/meta.yaml) and found some lint.

Here's what I've got...

For recipes/kneebow/meta.yaml:

  • ❌ There are too few lines. There should be one empty line at the end of the file.

For recipes/kneebow/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
  • ℹ️ No valid build backend found for Python recipe for package kneebow using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12639791846. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/kneebow/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/kneebow/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12639866171. Examine the logs at this URL for more detail.

@jaidevjoshi83
Copy link
Contributor Author

jaidevjoshi83 commented Jan 6, 2025

@conda-forge/help-python, ready for review

Copy link
Contributor

github-actions bot commented Jan 6, 2025

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@xl0
Copy link
Contributor

xl0 commented Jan 6, 2025

Any ideas why I got subscribed to this one? Got the email notificaiton.

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

@conda-forge/help-python, ready for review

He tagged the team

@github-actions github-actions bot added the python label Jan 6, 2025
@hhslepicka
Copy link
Contributor

Any ideas why I got subscribed to this one? Got the email notificaiton.

Same with me but I am not on the team help-python.

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

BTW I'd suggest you do the suggestions of the lint bot. It will mostly guide you when you need to change something.

@banesullivan
Copy link
Contributor

Look at the revision history of the comment, they tagged all-members

@carlodri
Copy link
Contributor

carlodri commented Jan 6, 2025

same here got pinged but I'm not in the help-python list...

@cudmore
Copy link

cudmore commented Jan 6, 2025 via email

@wolph
Copy link

wolph commented Jan 6, 2025

Just unsubscribe and stop replying everyone. Every reply here spams 6500 people...

I would suggest closing this issue and creating a new one so we don't require 6500 people to press the unsubscribe button.

@TomNicholas
Copy link
Contributor

Wait any of us can tag literally everyone who owns any conda package?!?

@banesullivan
Copy link
Contributor

@TomNicholas, just a casual 6,480 members... I don't see the big deal 😄

@btjanaka

This comment was marked as off-topic.

@ThiefMaster
Copy link

image

@the-praxs

This comment was marked as off-topic.

@yuvipanda
Copy link
Contributor

Mistakes happen folks, especially when you're doing something new! Let's encourage @jaidevjoshi83 to submit more packages and become a longer running member of this community by being welcoming to them.

And yes, this is fine as it means more people are trying to join the conda-forge ecosystem!

2E5CB038-F816-4AD9-9636-0ACAD36DA43E_1_105_c

Hit the unsubscribe button in the GitHub interface, as I have :)

I hope @jaidevjoshi83 actually gets the help they need!

@the-praxs
Copy link
Contributor

Mistakes happen folks, especially when you're doing something new! Let's encourage @jaidevjoshi83 to submit more packages and become a longer running member of this community by being welcoming to them.

And yes, this is fine as it means more people are trying to join the conda-forge ecosystem!

2E5CB038-F816-4AD9-9636-0ACAD36DA43E_1_105_c

Hit the unsubscribe button in the GitHub interface, as I have :)

I hope @jaidevjoshi83 actually gets the help they need!

u missing the fun

@jaidevjoshi83
Copy link
Contributor Author

I apologize to everyone. I was just trying to get my PR reviewed. I thought tagging the appropriate team was necessary for the review process. I sincerely apologize for any inconvenience caused.

@dact221
Copy link
Contributor

dact221 commented Jan 6, 2025

I'm unsubscribed and still receiving notifications:

image

@fcakyon
Copy link
Contributor

fcakyon commented Jan 6, 2025

Well, that was fun

Copy link
Contributor

@mahf708 mahf708 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ThiefMaster
Copy link

@jaidevjoshi83 Don't worry, I think everyone is having a lot of fun right now with this thread. :D

FWIW someone did that at work a year or two ago (with a large mailing list containing something like 20k people), and now there's a whole wall with memes about this whole thing now. It's hilarious, and there were no hard feelings from anyone :)

@hcwinsemius
Copy link
Contributor

hcwinsemius commented Jan 6, 2025 via email

Copy link
Member

@jjerphan jjerphan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo one suggestion.

Thank you for this addition, @jaidevjoshi83, and welcome if this is your first contribution!

recipes/kneebow/meta.yaml Show resolved Hide resolved
@qc00
Copy link

qc00 commented Jan 6, 2025

Great time to dust this old tale off again: https://www.reddit.com/r/sysadmin/comments/lng9si/the_great_microsoft_email_storm_of_1997/

@valentinsulzer
Copy link

Wait any of us can tag literally everyone who owns any conda package?!?

New DevTool marketing channel just dropped

@the-praxs
Copy link
Contributor

@jaidevjoshi83 Don't worry, I think everyone is having a lot of fun right now with this thread. :D

FWIW someone did that at work a year or two ago (with a large mailing list containing something like 20k people), and now there's a whole wall with memes about this whole thing now. It's hilarious, and there were no hard feelings from anyone :)

Someone tagged all 50K members in my university. Everybody checked their phones, even the professors.

Good memories!

@neilkakkar
Copy link

image image

@AuguB

This comment was marked as off-topic.

@Zeitsperre

This comment was marked as off-topic.

@valeriupredoi

This comment was marked as off-topic.

@hainm

This comment was marked as off-topic.

@hcwinsemius

This comment was marked as off-topic.

@giancastro

This comment was marked as off-topic.

@achimgaedke

This comment was marked as off-topic.

@the-praxs

This comment was marked as off-topic.

@lyehe

This comment was marked as off-topic.

@JWCook

This comment was marked as off-topic.

@conda-forge conda-forge locked as too heated and limited conversation to collaborators Jan 6, 2025
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/kneebow/meta.yaml) and found it was in an excellent condition.

@jaimergp
Copy link
Member

jaimergp commented Jan 6, 2025

@jaidevjoshi83, I have locked the conversation for now, although I'm not sure if that will prevent conda-forge contributors (those who already maintain a feedstock) from posting here 🤔

If you prefer, I'd suggest you close here and resubmit a new PR for a calmer review. Thanks for submitting your recipe to conda-forge!

@jaidevjoshi83 jaidevjoshi83 deleted the kneebow branch January 6, 2025 23:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.