-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding kneebow package #28770
Adding kneebow package #28770
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/kneebow/meta.yaml:
For recipes/kneebow/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12639791846. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/kneebow/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12639866171. Examine the logs at this URL for more detail. |
@conda-forge/help-python, ready for review |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
Any ideas why I got subscribed to this one? Got the email notificaiton. |
He tagged the team |
Same with me but I am not on the team help-python. |
BTW I'd suggest you do the suggestions of the lint bot. It will mostly guide you when you need to change something. |
Look at the revision history of the comment, they tagged |
same here got pinged but I'm not in the help-python list... |
Me to? Never subscribed (i think)?
…On Mon, Jan 6, 2025 at 1:18 PM Alexey Zaytsev ***@***.***> wrote:
Any ideas why I got subscribed to this one? Got the email notificaiton.
—
Reply to this email directly, view it on GitHub
<#28770 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHWMEA2KVSXDXOHO644YD32JLXJTAVCNFSM6AAAAABUWJYY62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZTHE2DANRQGY>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
|
Just unsubscribe and stop replying everyone. Every reply here spams 6500 people... I would suggest closing this issue and creating a new one so we don't require 6500 people to press the unsubscribe button. |
Wait any of us can tag literally everyone who owns any conda package?!? |
@TomNicholas, just a casual 6,480 members... I don't see the big deal 😄 |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Mistakes happen folks, especially when you're doing something new! Let's encourage @jaidevjoshi83 to submit more packages and become a longer running member of this community by being welcoming to them. And yes, this is fine as it means more people are trying to join the conda-forge ecosystem! Hit the unsubscribe button in the GitHub interface, as I have :) I hope @jaidevjoshi83 actually gets the help they need! |
u missing the fun |
I apologize to everyone. I was just trying to get my PR reviewed. I thought tagging the appropriate team was necessary for the review process. I sincerely apologize for any inconvenience caused. |
Well, that was fun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@jaidevjoshi83 Don't worry, I think everyone is having a lot of fun right now with this thread. :D FWIW someone did that at work a year or two ago (with a large mailing list containing something like 20k people), and now there's a whole wall with memes about this whole thing now. It's hilarious, and there were no hard feelings from anyone :) |
Let's also take the opportunity for wishing all great developers
contributing to conda-forge and package developers a happy new year!!!
Op ma 6 jan 2025 22:28 schreef Tom Nicholas ***@***.***>:
… Wait any of us can tag literally everyone who owns any conda package?!?
—
Reply to this email directly, view it on GitHub
<#28770 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB2NZMKCWLENUI6VV32GJLT2JLYQPAVCNFSM6AAAAABUWJYY62VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZTHE2DQNBVGU>
.
You are receiving this because you are on a team that was mentioned.Message
ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo one suggestion.
Thank you for this addition, @jaidevjoshi83, and welcome if this is your first contribution!
Great time to dust this old tale off again: https://www.reddit.com/r/sysadmin/comments/lng9si/the_great_microsoft_email_storm_of_1997/ |
New DevTool marketing channel just dropped |
Someone tagged all 50K members in my university. Everybody checked their phones, even the professors. Good memories! |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Co-authored-by: Julien Jerphanion <git@jjerphan.xyz>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@jaidevjoshi83, I have locked the conversation for now, although I'm not sure if that will prevent conda-forge contributors (those who already maintain a feedstock) from posting here 🤔 If you prefer, I'd suggest you close here and resubmit a new PR for a calmer review. Thanks for submitting your recipe to conda-forge! |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).