Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a recipe for SU2 #28726

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Add a recipe for SU2 #28726

wants to merge 17 commits into from

Conversation

martin-g
Copy link

@martin-g martin-g commented Dec 30, 2024

An Open-Source Suite for Multiphysics Simulation and Design

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/su2/meta.yaml) and found some lint.

Here's what I've got...

For recipes/su2/meta.yaml:

  • ❌ If python is a host requirement, it should be a run requirement.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12546287769. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/su2/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/su2/meta.yaml) and found some lint.

Here's what I've got...

For recipes/su2/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12547780080. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/su2/meta.yaml) and found it was in an excellent condition.

@martin-g martin-g force-pushed the su2 branch 5 times, most recently from 1141d3d to d1e808b Compare January 2, 2025 16:03
@martin-g martin-g marked this pull request as ready for review January 3, 2025 07:20
recipes/su2/meta.yaml Outdated Show resolved Hide resolved
@martin-g
Copy link
Author

martin-g commented Jan 3, 2025

@conda-forge/help-c-cpp this is ready for review

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/su2/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/su2/recipe.yaml:

  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12809640350. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/su2/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/su2/recipe.yaml) and found some lint.

Here's what I've got...

For recipes/su2/recipe.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12828927057. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/su2/meta.yaml) and found it was in an excellent condition.

@martin-g
Copy link
Author

Moved back to meta.yaml (conda-build) because it seems rattler-build does not respect the Python version defined in su2/conda_build_config.yaml

An Open-Source Suite for Multiphysics Simulation and Design

- https://su2code.github.io/
- https://github.com/su2code/SU2

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Build the PyWrapper too

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
```
30T12:32:50.8956625Z + ./meson.py build --prefix=/home/conda/staged-recipes/build_artifacts/su2_1735561883705/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho -Denable-openblas=true -Denable-pywrapper=true
2024-12-30T12:32:51.0384096Z error: pathspec '/home/conda/staged-recipes/build_artifacts/su2_1735561883705/work/externals/codi' did not match any file(s) known to git
2024-12-30T12:32:51.0395103Z Traceback (most recent call last):
2024-12-30T12:32:51.0395732Z   File "/home/conda/staged-recipes/build_artifacts/su2_1735561883705/work/./meson.py", line 39, in <module>
2024-12-30T12:32:51.0400208Z     preconfigure.run(own_meson=True)
2024-12-30T12:32:51.0401073Z   File "/home/conda/staged-recipes/build_artifacts/su2_1735561883705/work/preconfigure.py", line 88, in run
2024-12-30T12:32:51.0408187Z     init_submodules(
2024-12-30T12:32:51.0409151Z   File "/home/conda/staged-recipes/build_artifacts/su2_1735561883705/work/meson_scripts/init.py", line 112, in init_submodules
2024-12-30T12:32:51.0409727Z     submodule_status(alt_name_codi, sha_version_codi)
2024-12-30T12:32:51.0410197Z   File "/home/conda/staged-recipes/build_artifacts/su2_1735561883705/work/meson_scripts/init.py", line 189, in submodule_status
2024-12-30T12:32:51.0415548Z     status = subprocess.run(
2024-12-30T12:32:51.0416521Z   File "/home/conda/staged-recipes/build_artifacts/su2_1735561883705/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/lib/python3.9/subprocess.py", line 528, in run
2024-12-30T12:32:51.0422963Z     raise CalledProcessError(retcode, process.args,
2024-12-30T12:32:51.0423747Z subprocess.CalledProcessError: Command '['git', 'submodule', 'status', '/home/conda/staged-recipes/build_artifacts/su2_1735561883705/work/externals/codi']' returned non-zero exit status 1.
2024-12-30T12:32:52.7245214Z Traceback (most recent call last):
2024-12-30T12:32:52.7246507Z   File "/opt/conda/lib/python3.12/site-packages/conda_build/build.py", line 2557, in build
2024-12-30T12:32:52.7261429Z     utils.check_call_env(
```

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
martin-g and others added 8 commits January 20, 2025 10:48
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Try with libopenblas as host dependency

Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
@xhochy
Copy link
Member

xhochy commented Jan 20, 2025

Is this still ready for review?

@martin-g
Copy link
Author

@xhochy Yes!
I tried to migrate it to recipe.yaml (rattler-build) but it was not able to detect the version of Python (the recipe does not work with Python 3.12+) and reverted back to meta.yaml (conda-build). Now all is green again! Any feedback is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants