Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for audioop-lts #28515

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add recipe for audioop-lts #28515

wants to merge 5 commits into from

Conversation

kynan
Copy link
Contributor

@kynan kynan commented Dec 10, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/audioop-lts/meta.yaml) and found some lint.

Here's what I've got...

For recipes/audioop-lts/meta.yaml:

  • ❌ about/license_family 'PSF-2.0' not allowed. Allowed families are AGPL,
    APACHE, BSD, CC, GPL, GPL2, GPL3, LGPL, MIT, MOZILLA, NONE, OTHER,
    PROPRIETARY, PSF, and PUBLIC-DOMAIN.
  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ Non noarch packages should have python requirement without any version constraints.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12264172124. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/audioop-lts/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/audioop-lts/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12264225099. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/audioop-lts/meta.yaml) and found it was in an excellent condition.

@kynan kynan force-pushed the audioop-lts branch 2 times, most recently from 83d8f2d to 4762b8d Compare December 10, 2024 20:56
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/audioop-lts/meta.yaml) and found some lint.

Here's what I've got...

For recipes/audioop-lts/meta.yaml:

  • ❌ Non noarch packages should have python requirement without any version constraints.
  • ❌ This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12264568565. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/audioop-lts/meta.yaml) and found it was in an excellent condition.

@kynan
Copy link
Contributor Author

kynan commented Dec 10, 2024

@dopplershift This is the dependency that will hopefully unbreak conda-forge/audiogrep-feedstock#12

@kynan
Copy link
Contributor Author

kynan commented Dec 10, 2024

@conda-forge/help-python This should be good to merge.

@HeavyTony2
Copy link
Contributor

I think the package isn't ready yet to be added on Conda since it requires Python 3.13, which is not yet a default version. The whole builds are skipped. https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1105543&view=logs&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff&l=647
#28300

@kynan
Copy link
Contributor Author

kynan commented Dec 10, 2024

@HeavyTony2 Thanks for flagging! How can this be fixed? Note that this package only supports Python 3.13: https://github.com/AbstractUmbra/audioop

recipes/audioop-lts/meta.yaml Outdated Show resolved Hide resolved
recipes/audioop-lts/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: Filipe <ocefpaf@gmail.com>
@kynan
Copy link
Contributor Author

kynan commented Dec 11, 2024

@ocefpaf Looks like we're still not actually building anything:

Computed that there are 0 distributions to build from 1 recipes
Nothing to do

@kynan
Copy link
Contributor Author

kynan commented Dec 12, 2024

@conda-forge/help-python Any hints on how I can make CI actually build a package for Python 3.13 only?

@kynan
Copy link
Contributor Author

kynan commented Dec 20, 2024

@conda-forge/help-python Still looking for help with this.

@kynan
Copy link
Contributor Author

kynan commented Dec 28, 2024

@ocefpaf @conda-forge/help-python How can I configure this recipe to only build for Python 3.13? As is, no packages are built.

@ocefpaf
Copy link
Member

ocefpaf commented Jan 3, 2025

@ocefpaf @conda-forge/help-python How can I configure this recipe to only build for Python 3.13? As is, no packages are built.

There is an ongoing migration and staged-recipes doesn't build it until the migration is underway. You can add a conda_build_config.yaml file with:

python:
  - 3.13

in the recipe directory and see if that works to pick up the latest Python.

@kynan
Copy link
Contributor Author

kynan commented Jan 4, 2025

@ocefpaf Adding a conda_build_config.yaml apparently didn't work:

ValueError: variant config in /home/conda/staged-recipes-copy/recipes/audioop-lts/conda_build_config.yaml is ambiguous because it does not fully implement all zipped keys (missing ['numpy', 'python_impl']) or specifies a subspace that is not fully implemented (we did not find ['3.13'] from {'python': ['3.13']} in python:['3.9.* *_cpython', '3.10.* *_cpython', '3.11.* *_cpython', '3.12.* *_cpython']).

I suppose I'll have to pause this until the Python 3.13 migration is complete?

@kynan
Copy link
Contributor Author

kynan commented Jan 15, 2025

@conda-forge/help-python Still looking for help with my previous comment please.

@kynan
Copy link
Contributor Author

kynan commented Jan 26, 2025

@ocefpaf @conda-forge/help-python Could you please advise when the 3.13 migration will be complete?

@kynan
Copy link
Contributor Author

kynan commented Feb 1, 2025

@conda-forge-admin please restart ci

@kynan
Copy link
Contributor Author

kynan commented Feb 1, 2025

@conda-forge/help-python CI is now actually failing, as Python 3.13 doesn't seem to be available yet? Could you please advise when the 3.13 migration will be complete?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants