WIP: support Python 3.7 #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream problem is documented in rkern/line_profiler#132, but upstream seems unresponsive. This here tries to implement the fix suggested in the upstream issue by manually running Cython before pip installing. closes conda-forge#20
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
seems like there's no ci testing for 3.7 ... so i'll do some testing on my own then, please ignore until then. |
|
@conda-forge-admin, please rerender |
…da-forge-pinning 2019.07.01
|
I think if you rerender the recipe using the command above it should add CI for 3.7. edit: my comment above seems to have done the rerender (I wasn't sure if it would since this is not my PR) |
|
I don't think that |
|
Addressed in PR ( #22 ). Thanks for the effort here. 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)closes #20
Upstream problem is documented in rkern/line_profiler#132, but
upstream seems unresponsive.
This here tries to implement the fix suggested in the upstream issue
by manually running Cython before pip installing.
Haven't had a chance to really test this yet, but was hoping that the CI would take care of that ...