Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.7 #20

Closed
andreas-h opened this issue Mar 12, 2019 · 4 comments
Closed

Support Python 3.7 #20

andreas-h opened this issue Mar 12, 2019 · 4 comments

Comments

@andreas-h
Copy link

Apparently, Python3.7 builds fail, see rkern/line_profiler#129 and rkern/line_profiler#132.

It would be great if we could still get packages on conda-forge. There seem to be solutions available at rkern/line_profiler#132 (comment) and https://launchpadlibrarian.net/380639231/python-line-profiler_2.1-1build1_2.1-1ubuntu1.diff.gz

Please let me know if I can help.
@parejkoj
Copy link

parejkoj commented May 2, 2019

Is the problem a lack of a PR to fix it, or a lack of someone to shepherd the PR through?

@jakirkham
Copy link
Member

It sounds like this needs to be fixed upstream. If you're able to work on PRs to ensure upstream works on Python 3.7, that would help solve this issue I think.

@andreas-h
Copy link
Author

No activity upstream ... However , the fix I referenced above seems easy enough that it could be implemented here in the recipe for Python3.7. I could try prepare a PR next week if you would be willing to accept it.

andreas-h pushed a commit to andreas-h/line_profiler-feedstock that referenced this issue May 31, 2019
ENH: support Python 3.7
025d5d2 
Upstream problem is documented in rkern/line_profiler#132, but
upstream seems unresponsive.

This here tries to implement the fix suggested in the upstream issue
by manually running Cython before pip installing.

closes conda-forge#20
@andreas-h andreas-h mentioned this issue May 31, 2019
Closed
5 tasks
@grlee77 grlee77 mentioned this issue Jul 5, 2019
Merged
4 tasks
@jakirkham
Copy link
Member

Fixed with PR ( #22 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: support Python 3.7 andreas-h/line_profiler-feedstock
3 participants
@andreas-h @parejkoj @jakirkham