Skip to content

Commit

Permalink
Merge pull request #41 from conda-forge-admin/conda_forge_admin_40
Browse files Browse the repository at this point in the history
ENH carry patch for UTF-8-MAC
  • Loading branch information
mbargull authored Dec 15, 2023
2 parents 2463d72 + 9a6c1cd commit fdef45b
Show file tree
Hide file tree
Showing 5 changed files with 1,690 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/CODEOWNERS

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions README.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 9 additions & 3 deletions recipe/build.sh
Original file line number Diff line number Diff line change
@@ -1,16 +1,22 @@
#!/usr/bin/env sh

set -euxo pipefail

# Get an updated config.sub and config.guess
cp $BUILD_PREFIX/share/libtool/build-aux/config.* ./build-aux
cp $BUILD_PREFIX/share/libtool/build-aux/config.* ./libcharset/build-aux
set -ex

./configure --prefix=${PREFIX} \
--host=${HOST} \
--build=${BUILD} \
--enable-static \
--disable-rpath

make -j${CPU_COUNT} ${VERBOSE_AT}
if [[ "${CONDA_BUILD_CROSS_COMPILATION}" != "1" ]]; then
if [[ "${target_platform}" == osx-* ]]; then
make -f Makefile.devel CC="${CC_FOR_BUILD}" CFLAGS="${CFLAGS}"
fi

make -j${CPU_COUNT}
if [[ "${CONDA_BUILD_CROSS_COMPILATION:-0}" != "1" ]]; then
make check
fi
17 changes: 15 additions & 2 deletions recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,17 @@ source:
- CMakeLists.txt.patch # [win]
- config.h.patch # [win]
- configure.cmake.patch # [win]
- utf_8_mac.patch # [osx]

build:
number: 1

number: 2

requirements:
build:
- automake # [osx]
- autoconf # [osx]
- groff # [osx]
- gperf # [osx]
- libtool # [unix]
- {{ compiler('c') }}
- cmake # [win]
Expand Down Expand Up @@ -72,6 +76,7 @@ outputs:
license: LGPL-2.1-only
license_file: COPYING.LIB
summary: Provides iconv for systems which don't have one (or that cannot convert from/to Unicode.)

- name: iconv
script: install.sh
# there is no executable available on windows, see
Expand All @@ -90,11 +95,18 @@ outputs:
test:
commands:
- iconv --help
# print all supported encodings
- iconv -l | grep "UTF-8-MAC" # [osx]
# Ensure we run the built iconv and not the one from the base system.
- test "$(command -v iconv)" = "${PREFIX}/bin/iconv" # [unix]
# Test working patched-in UTF-8-MAC encoding.
- test "$(printf '\xc3\xa4' | iconv --from-code=UTF-8 --to-code=UTF-8-MAC)" = "$(printf '\x61\xcc\x88')" # [osx]
about:
home: https://www.gnu.org/software/libiconv/
license: GPL-3.0-only
license_file: COPYING
summary: Provides iconv for systems which don't have one (or that cannot convert from/to Unicode.)

about:
home: https://www.gnu.org/software/libiconv/
license: GPL-3.0-only AND LGPL-2.1-only
Expand All @@ -110,3 +122,4 @@ extra:
- jakirkham
- jhamman
- scopatz
- mbargull
Loading

1 comment on commit fdef45b

@conda-forge-webservices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This is the friendly automated conda-forge-webservice.

I updated the Github team because of this commit.

  • @mbargull was added to this feedstock maintenance team.

You should get push access to this feedstock and CI services.

Your package won't be available for installation locally until it is built
and synced to the anaconda.org CDN (takes 1-2 hours after the build finishes).

Feel free to join the community Element channel.

NOTE: Please make sure to not push to the repository directly.
Use branches in your fork for any changes and send a PR.
More details on this are here.

Please sign in to comment.