[feature] Add hooks for validate and validate_build methods #17856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
memsharded
reviewed
Feb 26, 2025
|
#17879 has been merged to develop2, please merge from develop2 to get rid of HookManager instantiation issue. |
memsharded
requested changes
Mar 3, 2025
| compatibility_file = os.path.join(compatibility_plugin_folder, "compatibility.py") | ||
| if not os.path.exists(compatibility_file): | ||
| raise ConanException("The 'compatibility.py' plugin file doesn't exist. If you want " | ||
| "to disable it, edit its contents instead of removing it") | ||
| mod, _ = load_python_file(compatibility_file) | ||
| self._compatibility = mod.compatibility | ||
| self._hook_manager = HookManager(HomePaths(cache_folder).hooks_path) |
There was a problem hiding this comment.
You shouldn't instantiate HookManager here anymore.
| unknown_mode = global_conf.get("core.package_id:default_unknown_mode", default="semver_mode") | ||
| non_embed = global_conf.get("core.package_id:default_non_embed_mode", default="minor_mode") | ||
| # recipe_revision_mode already takes into account the package_id | ||
| embed_mode = global_conf.get("core.package_id:default_embed_mode", default="full_mode") | ||
| python_mode = global_conf.get("core.package_id:default_python_mode", default="minor_mode") | ||
| build_mode = global_conf.get("core.package_id:default_build_mode", default=None) | ||
| self._modes = unknown_mode, non_embed, embed_mode, python_mode, build_mode | ||
| self._hook_manager = HookManager(HomePaths(self._home_folder).hooks_path) |
There was a problem hiding this comment.
Do not instantiate here a new HookManager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Hello!
This PR brings a new hooks for validate() and validate_build() methods.
The intention is to help CI services validate a build without touching the recipe, by adding an extra layer of validations. For instance, the CI environment could not build a determined package due to custom settings, or some system library is not available because the O.S. is too old.
Details
Both
validateandvalidate_builddon't have a specific command, like export or build, so I usedconan createto get a ride and check if is working.Also, both methods are not defined by default, which means, the hook will only run when one of these methods is defined in the recipe.
Automation
Changelog: Feature: Add hooks pre_validate, post_validate, pre_validate_build and post_validate_build
Docs: TODO
/cc @jcar87
developbranch, documenting this one.