Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor initializers #68

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Refactor initializers #68

merged 1 commit into from
Feb 3, 2025

Conversation

mikhailChelbaev
Copy link
Collaborator

Revise the initializers following these guidelines:

  • If a component can be configured with an initial model value, provide it with a default value.
  • If a view model includes properties crucial for a component's full appearance, avoid assigning a default model value.

For instance, a button requires the title parameter in the model to be set for it to appear complete, so no default value is provided. Conversely, a loader appears satisfactory with an initial model value, so a default value is provided.

@mikhailChelbaev mikhailChelbaev merged commit 3446130 into dev Feb 3, 2025
1 check passed
@mikhailChelbaev mikhailChelbaev deleted the refactor/inits branch February 3, 2025 15:52
@mikhailChelbaev mikhailChelbaev mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant