This repository has been archived by the owner on Dec 27, 2024. It is now read-only.
FSPT-189: Working lift & shift of Authenticator #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcUsher
force-pushed
the
feature/FSPT-189-authenticator-working-lift-shift
branch
from
fdea304 to
b4bf074
Compare
MarcUsher
force-pushed
the
feature/FSPT-189-authenticator-working-lift-shift
branch
from
b4bf074 to
e8c3ae1
Compare
MarcUsher
force-pushed
the
feature/FSPT-189-authenticator-working-lift-shift
branch
from
41424c5 to
5c2427a
Compare
MarcUsher
force-pushed
the
feature/FSPT-189-authenticator-working-lift-shift
branch
from
3a203b2 to
71e65d9
Compare
MarcUsher
force-pushed
the
feature/FSPT-189-authenticator-working-lift-shift
branch
from
71e65d9 to
2f2e620
Compare
MarcUsher
force-pushed
the
feature/FSPT-189-authenticator-working-lift-shift
branch
from
361592a to
c2cdce1
Compare
MarcUsher
force-pushed
the
feature/FSPT-189-authenticator-working-lift-shift
branch
from
c2cdce1 to
d72c771
Compare
MarcUsher
force-pushed
the
feature/FSPT-189-authenticator-working-lift-shift
branch
from
a9f100b to
14846d2
Compare
This commit is the bulk of the work to make the pre-award-frontend app now include the old `authenticator` service and make it work for `frontend`, `assess` and `authenticator`.
Our Authenticator and Assess Test Clients implement their own version of the set_cookie method so that we don't have to explicitly pass the domain every time we want to set the cookie in a test or request. However the default implementation of this method (see https://werkzeug.palletsprojects.com/en/stable/test/#werkzeug.test.Client.set_cookie) sets `origin_only` to True, meaning the domain must be an exact match to the request in order for a cookie to be set on the test request. This doesn't work with our implementation as we want a cookie to be set across the services. This commit switches our implementation of `set_cookie` to default `origin_only` to False.
CSRF has never been enabled on authenticator correctly, so this maintains existing behaviour. We should fix this... Exempt authenticator SSO endpoint from CSRF
Authenticator used a session cookie with Lax rather than Strict for the `session_cookie_samesite` in Talisman so that it could send people to Microsoft logins. Assess had it set to Strict for this same setting. Now that we've brought the frontends together this needs to be set to Lax otherwise you can't log into Find or Submit.
MarcUsher
force-pushed
the
feature/FSPT-189-authenticator-working-lift-shift
branch
from
dcd029b to
23493a5
Compare
samuelhwilliams
approved these changes
Dec 20, 2024
MarcUsher
deleted the
feature/FSPT-189-authenticator-working-lift-shift
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Lift & shift of
authenticatorintopre-award-frontendand updates to consolidate shared modules (config, copilot, github etc.) and make the applications work as a single application withauthenticatorspecific code in its own module.All existing
authenticatortests pass.How to test
feature/FSPT-189-authenticator-into-pre-award-frontendondocker-runnerpre-award-frontendandmake upcontainers