Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to work even if there are multiple Content-Type headers #754

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

suecharo
Copy link
Contributor

@suecharo suecharo commented Oct 6, 2023

Discussed in issue#747

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can you run make dev cleanup inside a virtualenv?

@suecharo
Copy link
Contributor Author

Sorry and thank you. I did it.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #754 (b11a946) into main (acd1cd5) will not change coverage.
The diff coverage is 60.00%.

❗ Current head b11a946 differs from pull request most recent head 827ab07. Consider uploading reports for the commit 827ab07 to get more accurate results

@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   83.68%   83.68%           
=======================================
  Files          22       22           
  Lines        4580     4580           
  Branches     1239     1239           
=======================================
  Hits         3833     3833           
  Misses        483      483           
  Partials      264      264           
Files Coverage Δ
schema_salad/fetcher.py 66.37% <60.00%> (ø)

@mr-c mr-c enabled auto-merge (squash) October 10, 2023 06:08
@mr-c mr-c merged commit f2a8461 into common-workflow-language:main Oct 10, 2023
33 checks passed
@suecharo
Copy link
Contributor Author

@mr-c
I have confirmed that the merge has been successfully completed. May I inquire about the schedule for its release, and furthermore, its integration with cwltool?

I apologize for any inconvenience my request might cause amidst your busy schedule, and appreciate your assistance in advance.

Thank you very much.

Hiro

@mr-c
Copy link
Member

mr-c commented Oct 25, 2023

Thanks for the reminder, Hiro.

I've released https://pypi.org/project/schema-salad/8.4.20231024070348/ a.k.a. https://github.com/common-workflow-language/schema_salad/releases/tag/8.4.20231024070348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants