Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing basket examples #542

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Conversation

bblfish
Copy link
Contributor

@bblfish bblfish commented Jun 4, 2022

see #541

It turns out that the code in the README was ok as is, but for some reason the first few times I tried it I could not get it to work at all, so I thought that the examples in the README were missing something. That led me to search in the history.
After adding them to the repo I found that it worked.

Note that I am not a python programmer, I am new to yaml, and to the whole project, so it could have been simple things like formatting that were the problem. But that is good reason to add those examples to the repository, and perhaps even test them with the unit tests (but I am not sure how to do that yet)

$ schema-salad-tool basket_schema.yml basket.yml
/Users/hjs/Library/Python/3.8/bin/schema-salad-tool Current version: 8.3.20220525163636
Document `basket.yml` is valid

@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #542 (78f7d7f) into main (73cf507) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   81.54%   81.54%           
=======================================
  Files          19       19           
  Lines        3635     3635           
  Branches     1009     1009           
=======================================
  Hits         2964     2964           
  Misses        436      436           
  Partials      235      235           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73cf507...78f7d7f. Read the comment docs.

@mr-c mr-c requested a review from tetron June 7, 2022 10:00
@mr-c
Copy link
Member

mr-c commented Jun 7, 2022

Thank you @bblfish ! I've asked @tetron to double check this before we merge.

@mr-c mr-c merged commit 8f6e232 into common-workflow-language:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants